Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(FormControl): update FormControl to use CSS Modules behind flag #5438

Merged
merged 17 commits into from
Dec 19, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Dec 13, 2024

Closes https://github.com/github/primer/issues/3812

Changelog

New

Changed

  • Update FormControl and shared internal components to use form control behind feature flag

Removed

Rollout strategy

  • Minor release

Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: bb0a9da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 13, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Dec 13, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.69 KB (+0.35% 🔺)
packages/react/dist/browser.umd.js 104 KB (+0.32% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5438 December 13, 2024 17:37 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 13, 2024
@hussam-i-am hussam-i-am self-assigned this Dec 18, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5438 December 18, 2024 18:51 Inactive
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 18, 2024
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 18, 2024
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5438 December 18, 2024 21:14 Inactive
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 18, 2024
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 18, 2024
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@hussam-i-am hussam-i-am marked this pull request as ready for review December 18, 2024 21:31
@hussam-i-am hussam-i-am requested a review from a team as a code owner December 18, 2024 21:31
@hussam-i-am hussam-i-am requested a review from jonrohan December 18, 2024 21:31
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 18, 2024
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/355840

@hussam-i-am
Copy link
Collaborator

hussam-i-am commented Dec 18, 2024

ab12bde adds the missing sx prop that was not being passed in for vertical layouts, which resolves the input not getting the full width styling that was being passed in on the "Create new issue" page.

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RL looks good 👍

@jonrohan jonrohan added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 4776d13 Dec 19, 2024
42 checks passed
@jonrohan jonrohan deleted the refactor/update-form-control-to-css-modules-3 branch December 19, 2024 01:40
@primer primer bot mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants