-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(FormControl): update FormControl to use CSS Modules behind flag #5438
refactor(FormControl): update FormControl to use CSS Modules behind flag #5438
Conversation
…hind feature flag
Co-authored-by: Katie Langerman <[email protected]>
…orm-control-to-css-modules-3
🦋 Changeset detectedLatest commit: bb0a9da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
…update-form-control-to-css-modules-3
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
…ol-to-css-modules-3
…://github.com/primer/react into refactor/update-form-control-to-css-modules-3
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/355840 |
ab12bde adds the missing sx prop that was not being passed in for vertical layouts, which resolves the input not getting the full width styling that was being passed in on the "Create new issue" page. |
🟢 golden-jobs completed with status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RL looks good 👍
Closes https://github.com/github/primer/issues/3812
Changelog
New
Changed
Removed
Rollout strategy