Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Pagination): Remove sxProp #5429

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(Pagination): Remove sxProp #5429

wants to merge 3 commits into from

Conversation

JelloBagel
Copy link
Contributor

Changelog

Changed

Convert Box to div

Removed

Remove SxProp from Pagination because there are no results on Primer Query: https://primer-query.githubapp.com/?attribute=%22sx%22&name=pagination

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d1776f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JelloBagel JelloBagel force-pushed the jellobagel-pagination-sxprop branch from b897bd6 to 4bba270 Compare December 12, 2024 20:29
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5429 December 12, 2024 20:31 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.2 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 103.59 KB (-0.03% 🔽)

JelloBagel
JelloBagel commented Dec 12, 2024
View reviewed changes
packages/react/src/Pagination/Pagination.tsx
@@ -275,14 +270,12 @@ function Pagination({
{...rest}
theme={theme}
>
<Box
display="inline-block"
theme={theme}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if theme is still used here anymore

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/354916

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 12, 2024
@JelloBagel JelloBagel marked this pull request as ready for review December 12, 2024 22:19
@JelloBagel JelloBagel requested a review from a team as a code owner December 12, 2024 22:19
@JelloBagel JelloBagel changed the title feat(Pagination): Remove sx prop feat(Pagination): Remove sxProp Dec 13, 2024
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@JelloBagel JelloBagel removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 13, 2024
francinelucca
francinelucca approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca approved these changes

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelloBagel @francinelucca