feat(LabelGroup): Remove sxProp

[JelloBagel]

• Closes https://github.com/github/primer/issues/4262

Changelog

New

Add DeprecatedSxProp interface for future deprecated sx components

Changed

Convert Box to div

Removed

Remove SxProp from LabelGroup because there are no results on Primer Query: https://primer-query.githubapp.com/?attribute=%22sx%22&name=labelgroup

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: 48a5d19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	103.3 KB (+0.1% 🔺)
packages/react/dist/browser.umd.js	103.65 KB (+0.04% 🔺)

[github-actions]

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

[github-actions]

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

[JelloBagel]

Adding DeprecatedSxProp for other components to use in the batch: https://github.com/github/primer/issues/4261

cc: @lindseywild

[langermank]

Maybe Stack won't work very well here, I'm not really sure. If we keep the classes could we rename them to be more specific like how we write component CSS elsewhere? I know these are generated but just thinking it could be cleaner for this case to be named 😄 this is nitpicky and not blocking

[langermank]

Suggested change

	<div className={classes.Div_0} style={{width: overlayWidth, padding: `${overlayPaddingPx}px`}}>
	<div className={classes.Div_1}>{children}</div>
	<Stack align="start" style={{width: overlayWidth, padding: `${overlayPaddingPx}px`}}>
	<StackItem><Stack wrap="wrap" gap="condensed">{children}</Stack></StackItem>

I guess condensed is 8px, though 🤷

[github-actions]

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

[JelloBagel]

@langermank let me know what you think of the new classnames (naming is hard 😅): a32da29. I'll test replacing the div with Stack in a separate PR.

Since removing sx is intended for the next major per slack (hubbers only), I replaced the div with Stack here: 9d1757d

[github-actions]

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

[github-actions]

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

[primer-integration]

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/354877

[primer-integration]

🟢 golden-jobs completed with status success.