Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(AutoComplete): add e2e tests #5417

Merged
merged 32 commits into from
Dec 17, 2024

Conversation

francinelucca
Copy link
Member

Relates to https://github.com/github/primer/issues/4303

Changelog

New

  • e2e test file for AutoComplete
  • Dev story for AutoComplete to test sx and style props in VRT
  • Adds classname unit test to Autocomplete.Input and Autocomplete.Overlay

Changed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Test/Docs only change

Testing & Reviewing

Merge checklist

@francinelucca francinelucca requested a review from a team as a code owner December 11, 2024 21:44
Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: 43ebdc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Dec 11, 2024
@francinelucca francinelucca added integration-tests: skipped manually Changes in this PR do not require an integration test staff Author is a staff member and removed staff Author is a staff member labels Dec 11, 2024
@francinelucca francinelucca marked this pull request as draft December 11, 2024 21:45
@github-actions github-actions bot temporarily deployed to storybook-preview-5417 December 11, 2024 21:47 Inactive
Copy link
Contributor

github-actions bot commented Dec 11, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.22 KB (0%)
packages/react/dist/browser.umd.js 103.6 KB (0%)

@hussam-i-am hussam-i-am added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit bd568fd Dec 17, 2024
42 checks passed
@hussam-i-am hussam-i-am deleted the francinelucca/e2e-tests/autocomplete branch December 17, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Autocomplete integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants