Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react): update build output to use dist dir #5352

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshblack
Copy link
Member

This moves us closer to our end goal for how we want to bundle up @primer/react 👀. In this PR, we update our rollup config to emit all package files into the dist directory and make the corresponding changes in package.json to point to the new location of things.

In the future, we'll likely have this dist directory only be exporting ESM files.

This change will also make it a little easier for us to start to enable tools like publint as it's a little easier for us to dual emit types for CJS/ESM (if we want to do that before moving to ESM).

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: dd8d40a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Dec 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.3 KB (0%)
packages/react/dist/browser.umd.js 104.59 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant