Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(Flash): Add aria-label to stories with icons #4982

Merged

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Sep 17, 2024

Closes https://github.com/github/primer/issues/3483

Changelog

Changed

  • Adds aria-label to Flash stories with icons to improve accessibility.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Storybook change only

Testing & Reviewing

See deployed Flash features stories and verify all icons have an aria-label that is accessible by screen readers.

Merge checklist

Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: fb448a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.58 KB (0%)
packages/react/dist/browser.umd.js 97.7 KB (0%)

@francinelucca
Copy link
Member Author

Note: since Flash is listed under deprecated components in our docs, wondering if we should put it under deprecated in SB as well?

@francinelucca francinelucca marked this pull request as ready for review September 17, 2024 18:14
@francinelucca francinelucca requested a review from a team as a code owner September 17, 2024 18:14
@francinelucca francinelucca added the staff Author is a staff member label Sep 17, 2024
@francinelucca
Copy link
Member Author

Note: since Flash is listed under deprecated components in our docs, wondering if we should put it under deprecated in SB as well?

Not necessary at the moment! react's Flash not fully deprecated yet

@francinelucca francinelucca added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 82a3552 Sep 18, 2024
46 of 47 checks passed
@francinelucca francinelucca deleted the 3483-prcflash-icon-examples-lack-a-text-alternative branch September 18, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member status: review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants