Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the CSS modules feature flag from Blankslate #4981

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

jonrohan
Copy link
Member

Closes https://github.com/github/primer/issues/3696

Changelog

Removed

Removes the feature flag from the Blankslate component to always render with CSS modules.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: d98bf21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 17, 2024
Copy link
Contributor

github-actions bot commented Sep 17, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.58 KB (0%)
packages/react/dist/browser.umd.js 97.7 KB (0%)

@jonrohan jonrohan marked this pull request as ready for review September 17, 2024 17:44
@jonrohan jonrohan requested a review from a team as a code owner September 17, 2024 17:44
@jonrohan jonrohan added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit c8fe1c6 Sep 17, 2024
32 checks passed
@jonrohan jonrohan deleted the remove_blankslate_css_modules_feature_flag branch September 17, 2024 21:20
@primer primer bot mentioned this pull request Sep 17, 2024
TylerJDev pushed a commit that referenced this pull request Sep 23, 2024
* Removing the css modules feature flag from blankslate

* Create dull-turkeys-cheer.md
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants