Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update eslint-plugin-github to v4.10 #3805

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

joshblack
Copy link
Member

Background https://github.com/github/primer/issues/2757

This is for the "All repos are using latest accessibility linting configs." criteria and updates primer/react to use eslint-plugin-github 4.9.2 or greater (4.10 in our case)

Changelog

New

Changed

  • Update eslint-plugin-github
  • Update svg elements to include aria-hidden
  • Remove unnecessary title element
  • Add lint ignore for VisuallyHidden element that seems to be an intentional choice from the a11y review

Removed

Rollout strategy

None

Testing & Reviewing

  • Verify the lint job passes as expected
  • Verify that changes do not regress any behavior or semantics

@joshblack joshblack requested review from a team and broccolinisoup October 10, 2023 20:52
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

⚠️ No Changeset found

Latest commit: a9d77a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.74 KB (-0.02% 🔽)
dist/browser.umd.js 105.32 KB (-0.01% 🔽)

@joshblack joshblack temporarily deployed to github-pages October 10, 2023 20:59 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3805 October 10, 2023 20:59 Inactive
@joshblack joshblack added the skip changeset This change does not need a changelog label Oct 10, 2023
src/Select/Select.tsx Show resolved Hide resolved
@joshblack joshblack enabled auto-merge October 12, 2023 16:01
@joshblack joshblack temporarily deployed to github-pages October 12, 2023 16:08 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3805 October 12, 2023 16:09 Inactive
@joshblack joshblack temporarily deployed to github-pages October 12, 2023 16:44 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3805 October 12, 2023 16:44 Inactive
@joshblack joshblack added this pull request to the merge queue Oct 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 12, 2023
@joshblack joshblack added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit b99b3ee Oct 12, 2023
29 of 30 checks passed
@joshblack joshblack deleted the chore/update-eslint-plugin-github-to-4.10 branch October 12, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants