Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MarkdownEditor story to testing #3633

Merged
merged 20 commits into from
Sep 13, 2023
Merged

Conversation

green6erry
Copy link
Contributor

@green6erry green6erry commented Aug 14, 2023

Parent issue: https://github.com/github/primer/issues/1488

Add storybook stories for MarkdownEditor

Checklist

  • Ensure your chosen component has a component directory in the src directory
  • Ensure the component has a root story file in the component directory
  • Ensure that the root story file exports a Default story
  • (Optional) Create a Playground story
  • Move all other stories for the component into a .features.stories.tsx file
  • Opt the component into storybook tests
  • (Optional) Create visual regression tests for the component

@green6erry green6erry added the skip changeset This change does not need a changelog label Aug 14, 2023
@green6erry green6erry requested review from a team and josepmartins August 14, 2023 20:37
@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

⚠️ No Changeset found

Latest commit: 4b92de8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 100.7 KB (0%)
dist/browser.umd.js 101.29 KB (0%)

@green6erry green6erry temporarily deployed to github-pages August 14, 2023 20:46 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3633 August 14, 2023 20:47 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3633 August 15, 2023 17:57 Inactive
@green6erry green6erry temporarily deployed to github-pages August 15, 2023 18:00 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3633 August 15, 2023 18:00 Inactive
@green6erry green6erry temporarily deployed to github-pages August 28, 2023 13:55 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3633 August 28, 2023 13:55 Inactive
@green6erry green6erry temporarily deployed to github-pages August 28, 2023 15:34 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3633 August 28, 2023 15:35 Inactive
@lesliecdubs
Copy link
Member

Has this one been waiting for a review for awhile @green6erry? I can escalate if needed.

@lesliecdubs lesliecdubs requested review from broccolinisoup and removed request for josepmartins August 29, 2023 00:25
@green6erry green6erry temporarily deployed to github-pages August 30, 2023 01:23 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3633 August 30, 2023 01:23 Inactive
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a comment, let me know what you think but overall looks great!

Thanks so much for pushing this PR 🙏🏻

@green6erry green6erry temporarily deployed to github-pages September 1, 2023 00:36 — with GitHub Actions Inactive
@green6erry green6erry temporarily deployed to github-pages September 5, 2023 13:21 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3633 September 5, 2023 13:22 Inactive
@green6erry green6erry temporarily deployed to github-pages September 5, 2023 13:57 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3633 September 5, 2023 13:58 Inactive
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a comment to remove the decorators - let me knowif you have any questions about that 😊

@green6erry green6erry temporarily deployed to github-pages September 8, 2023 17:38 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3633 September 8, 2023 17:38 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3633 September 12, 2023 23:13 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3633 September 12, 2023 23:14 Inactive
@green6erry green6erry temporarily deployed to github-pages September 13, 2023 13:18 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3633 September 13, 2023 13:19 Inactive
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@green6erry green6erry added this pull request to the merge queue Sep 13, 2023
Merged via the queue into main with commit a3f14f7 Sep 13, 2023
30 checks passed
@green6erry green6erry deleted the docs/add-markdownEditor-stories branch September 13, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants