Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageHeader: Address general sign-off feedback (missing links and action menu items) #3157

Closed
wants to merge 9 commits into from

Conversation

broccolinisoup
Copy link
Member

Describe your changes here.

Closes # (type the issue number after # if applicable; otherwise remove this line)

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Apr 12, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023

⚠️ No Changeset found

Latest commit: abf32a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.74 KB (0%)
dist/browser.umd.js 105.32 KB (0%)

@broccolinisoup broccolinisoup temporarily deployed to github-pages April 12, 2023 08:02 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3157 April 12, 2023 08:03 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages May 24, 2023 08:17 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3157 May 24, 2023 08:18 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages May 24, 2023 08:26 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3157 May 24, 2023 08:27 Inactive
@lesliecdubs
Copy link
Member

👋🏻 @broccolinisoup is this still active or should we consider closing it?

@broccolinisoup
Copy link
Member Author

@lesliecdubs it is active, sorry was holding it until the sign-off is completed but that will take a while. I added to my to-do list to clean up and open for review for next week.

@broccolinisoup broccolinisoup temporarily deployed to github-pages July 18, 2023 05:26 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3157 July 18, 2023 05:27 Inactive
@github-actions
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 16, 2023
@broccolinisoup broccolinisoup temporarily deployed to github-pages September 18, 2023 00:16 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3157 September 18, 2023 00:17 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages October 9, 2023 00:37 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3157 October 9, 2023 00:38 Inactive
@broccolinisoup broccolinisoup force-pushed the pageheader-sign-off-fixes branch from cfd647c to 1a17796 Compare October 12, 2023 05:59
@broccolinisoup broccolinisoup temporarily deployed to github-pages October 12, 2023 06:13 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3157 October 12, 2023 06:13 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages October 13, 2023 05:19 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3157 October 13, 2023 05:19 Inactive
@broccolinisoup broccolinisoup changed the title PageHeader: Adjustments to the storybook and docs examples (sign-off review) PageHeader: Address general sign-off feedback (missing links and action menu items) Oct 13, 2023
@broccolinisoup broccolinisoup temporarily deployed to github-pages October 13, 2023 05:59 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3817 October 13, 2023 05:59 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants