Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COART-181]: Check Gracefully termination in all our applications #211

Conversation

frnmjn
Copy link
Contributor

@frnmjn frnmjn commented Dec 5, 2024

This introduces a way to disable the dead letter key check here: #129 because in some scenarios, fixing this misconfiguration is not so easy.

This introduces also a way to run the test suite locally

@frnmjn frnmjn force-pushed the COART-181/feature/check-gracefully-termination-in-all-our-applications-disable-check branch 2 times, most recently from e7a4ed5 to 23fd8fa Compare December 6, 2024 10:39
@frnmjn frnmjn force-pushed the COART-181/feature/check-gracefully-termination-in-all-our-applications-disable-check branch from 23fd8fa to 02d45f0 Compare December 6, 2024 10:48
@frnmjn frnmjn marked this pull request as ready for review December 6, 2024 10:53
@frnmjn frnmjn requested a review from a team as a code owner December 6, 2024 10:53
@frnmjn frnmjn requested a review from a team December 6, 2024 10:53
cpiemontese
cpiemontese previously approved these changes Dec 6, 2024
@frnmjn frnmjn force-pushed the COART-181/feature/check-gracefully-termination-in-all-our-applications-disable-check branch from 40f5dac to da92a11 Compare December 6, 2024 11:19
Copy link
Contributor

@cpiemontese cpiemontese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the extended name 👏

@cpiemontese cpiemontese merged commit 339510d into master Dec 6, 2024
3 checks passed
@cpiemontese cpiemontese deleted the COART-181/feature/check-gracefully-termination-in-all-our-applications-disable-check branch December 6, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants