-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add space in header regex #598
base: master
Are you sure you want to change the base?
Conversation
4b5e197
to
f29b4e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of this change, but I'd like to hear from another reviewer, since some markdown implementations don't require spaces. https://babelmark.github.io/?text=%23asdf
We could add an option to toggle this behavior. Maybe What do you think, @tomtomjhj? |
See comment in #604 (comment) that covers why we don't know whether this should be merged directly or not. The discussion about what Markdown flavor we are even targeting needs to be resolved first. |
Also just for the record these two PRs are not duplicates, one addresses the syntax rules and one addresses the header level handling rules. Both should be merged, modified, or rejected in the same way. |
d23846e
to
aa0dafb
Compare
Fixes #597
Also adds some tests for
HeaderDecrease
andHeaderIncrease
.