-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test workflows #372
Add test workflows #372
Conversation
65c6822
to
7629f35
Compare
50637e0
to
d9c87f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, mostly on documentation. The main aspect I am worried about is the UID/GID hard-coding.
Caching seems to work locally. Running the same test case twice, I get:
First time:
./tools/tests [add-test-workflows]$ python3 ./systemtests.py --suites=fenics_test
Using log-level: INFO
INFO: About to run the following systemtest in the directory /home/gc/repos/precice/tutorials/runs:
[Flow over heated plate (fluid-openfoam, solid-fenics)]
INFO: Started running Flow over heated plate (fluid-openfoam, solid-fenics), 0/1
INFO: Running Flow over heated plate (fluid-openfoam, solid-fenics) took 1524.1612270610058 seconds
INFO: Success running Flow over heated plate (fluid-openfoam, solid-fenics)
+---------------------------------------------------------+---------+-------------------+-----------------+-----------------------+
| systemtest | success | building time [s] | solver time [s] | fieldcompare time [s] |
+---------------------------------------------------------+---------+-------------------+-----------------+-----------------------+
| Flow over heated plate (fluid-openfoam, solid-fenics) | 1 | 1272.33 | 157.36 | 92.69 |
+---------------------------------------------------------+---------+-------------------+-----------------+-----------------------+
Second time:
./tools/tests [add-test-workflows]$ python3 ./systemtests.py --suites=fenics_test
Using log-level: INFO
INFO: About to run the following systemtest in the directory /home/gc/repos/precice/tutorials/runs:
[Flow over heated plate (fluid-openfoam, solid-fenics)]
INFO: Started running Flow over heated plate (fluid-openfoam, solid-fenics), 0/1
INFO: Running Flow over heated plate (fluid-openfoam, solid-fenics) took 178.49133943999186 seconds
INFO: Success running Flow over heated plate (fluid-openfoam, solid-fenics)
+---------------------------------------------------------+---------+-------------------+-----------------+-----------------------+
| systemtest | success | building time [s] | solver time [s] | fieldcompare time [s] |
+---------------------------------------------------------+---------+-------------------+-----------------+-----------------------+
| Flow over heated plate (fluid-openfoam, solid-fenics) | 1 | 1.64 | 161.08 | 14.06 |
+---------------------------------------------------------+---------+-------------------+-----------------+-----------------------+
This is also reflected in the ./runs/<id>/stdout.log
file, where I see CACHED
in all layers before the actual solver execution.
On GitHub Actions, while the cache is updated, (see the versions next to each name), we do not hit it, so the jobs do take a long time to run (rebuilding the images). @valentin-seitz could you please post a link to the bug you mentioned?
I think this issues also describes our problem quite well: |
This PR does some things: