-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.2.0 #184
Merged
Merged
Release v2.2.0 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add dockerfile used for `benjaminrodenberg/fenics` * Use `pip install --break-system-packages ...`.
* Fixes tests
* Add tests to check if SolverState stores and returns the checkpointed state correctly --------- Co-authored-by: Benjamin Rodenberg <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
…ing installation (#181) * Require mpi4py < 4 --------- Co-authored-by: Benjamin Rodenberg <[email protected]>
This was referenced Oct 25, 2024
IshaanDesai
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code related changes make sense; the CI stuff not so much.
IshaanDesai
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My earlier comments have been addressed to a reasonable degree. Release is good to go 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release comes with some minor modifications to simplify the installation process and an important bugfix when subcycling is used (see #172).