Extend instead of overrride PATH in tests #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidscn
reviewed
Nov 7, 2024
| @@ -135,7 +135,7 @@ foreach(example IN LISTS _examples) | |||
| set_tests_properties(aste.example.${example} aste.example.${example}.setup | |||
| PROPERTIES | |||
| WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}/examples/${example}" | |||
| ENVIRONMENT "PATH=$ENV{PATH}:${CMAKE_BINARY_DIR}" | |||
There was a problem hiding this comment.
Is this also how we handle this in our preCICE profiling tests?
There was a problem hiding this comment.
There, the test directly calls the file, so PATH modifications aren't required.
There was a problem hiding this comment.
And in our case the python script calls the file, right?
Since the diff at the end is part of the test: can we do something similar here?
There was a problem hiding this comment.
In this case, CTest calls the run.sh, which calls the precice-aste-* scripts.
The run.sh needs the updated PATH.
One could pass the binary directory by argument to the script, but this seems a bit unintuitive for users that try to run the example.
Does this answer your questions?
davidscn
reviewed
Nov 7, 2024
davidscn
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
This allows to change PATH after configuring and building ASTE.
It also allows to use a venv created afterward building.
Author's checklist
pre-commithook and usedpre-commit run --allto apply all available hooks.docs/README.md../changelog-entries/(create if necessary).precice/tutorials/aste-turbine.