-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable partitioning algorithm in mapping tester #214
base: develop
Are you sure you want to change the base?
Conversation
@@ -111,6 +111,7 @@ def main(argv): | |||
print('Warning: outdir "{}" already exisits.'.format(outdir)) | |||
meshdir = os.path.join(outdir, "meshes") | |||
function = setup["general"]["function"] | |||
algorithm = setup["general"].get("partitioning", "meshfree") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the default ´"meshfree"´ to be backwards-compatible. It is an open question if this is desirable though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's ok.
precice-aste-partition --help
lists available options. I would suggest to put a note for the kmeans variant, stating that the result is non-deterministic and not reproducible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment in the code or a message in the script output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say "user visible", i.e., in the script output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was more thinking of a comment here
aste/src/precice-aste-partition
Lines 163 to 167 in d2c6fae
help="""Change the algorithm used for determining a partition. | |
A meshfree algorithm works on arbitrary meshes without needing topological information. | |
A topology-based algorithm needs topology information | |
and is therefore useless on point clouds. | |
A uniform algorithm will assume a uniform 2d mesh laid out somehow in 3d and partition accordingly.""", |
In the end, the behavior is not specific to the mapping-tester, but to the partitioning, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see what you mean.
I think we need both as the help text needs to be read.
A warning in the partition script will fill the terminal when testing many rank combinations in the mapping tester.
Main changes of this PR
Author's checklist
pre-commit
hook and usedpre-commit run --all
to apply all available hooks.docs/README.md
../changelog-entries/
(create if necessary).precice/tutorials/aste-turbine
.