Refactor mapping tester using snake style naming #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kursatyurt
changed the title
davidscn
reviewed
Dec 16, 2022
There was a problem hiding this comment.
Can you have a look at the failing tests?
I'm not too sure about renaming the python scripts as well. Note that the generate script generates runall.sh as well as postprocessall.sh. Do you also want to rename these files then? Maybe a better name for generate_mapping_test would be generate_mapping_test_cases?
|
|
||
| # Prepare the meshes | ||
| python3 "${MAPPING_TESTER}"/preparemeshes.py --setup "${TEST_LOCATION}"/setup-test.json --outdir "${TEST_CASE_LOCATION}" --force | ||
| python3 "${MAPPING_TESTER}"/prepare_mapping_teest_meshes.py --setup "${TEST_LOCATION}"/setup-test.json --outdir "${TEST_CASE_LOCATION}" --force |
There was a problem hiding this comment.
Suggested change
| python3 "${MAPPING_TESTER}"/prepare_mapping_teest_meshes.py --setup "${TEST_LOCATION}"/setup-test.json --outdir "${TEST_CASE_LOCATION}" --force | |
| python3 "${MAPPING_TESTER}"/prepare_mapping_test_meshes.py --setup "${TEST_LOCATION}"/setup-test.json --outdir "${TEST_CASE_LOCATION}" --force |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Refactoring mapping tester using snake naming convention. It follows the preCICE convention
C++ codes -> CamelCase
Python Scripts -> snake_case
Author's checklist
pre-commithook and usedpre-commit run --allto apply all available hooks.docs/README.md.precice/tutorials/aste-turbine.