Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue: Add bidFloor and currency param. Change current values configuration. #4115

Closed
wants to merge 10 commits into from

Conversation

samuelfabel
Copy link
Contributor

@samuelfabel samuelfabel commented Dec 18, 2024

This pull request refers to:

  1. Adding two new parameters, bidFloor and currency, to the bidder-params of the Blue bidder.
  2. Updating the placementId parameter to make it required.

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, bec988b

blue

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blue/blue.go:20:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:28:	MakeRequests	85.7%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:49:	MakeBids	100.0%
total:								(statements)	95.8%

@samuelfabel
Copy link
Contributor Author

We decided that we will do another implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants