Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adnuntius: Use format=prebidServer on adserver requests #4094

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

antosarho
Copy link
Contributor

Instead of format=json, use format=prebidServer in adserver requests.

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, adfa65b

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:99:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:109:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:113:	setHeaders		100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:129:	makeEndpointUrl		92.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:178:	getImpSizes		90.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:201:	generateRequests	92.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:317:	MakeBids		81.8%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:344:	getSiteExtAsKv		80.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:354:	getGDPR			92.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:379:	generateReturnExt	86.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:413:	generateAdResponse	82.1%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:486:	generateBidResponse	88.0%
total:									(statements)		89.4%

@bsardo bsardo self-assigned this Dec 12, 2024
@SyntaxNode SyntaxNode self-assigned this Dec 12, 2024
@bsardo bsardo changed the title Adnuntius: Use format=prebidServer on adserver requests. Adnuntius: Use format=prebidServer on adserver requests Dec 12, 2024
@bsardo bsardo merged commit 78d07be into prebid:master Dec 12, 2024
5 checks passed
scr-oath pushed a commit to scr-oath/prebid-server that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants