New Adapter: Ogury #4082

krdzo · 2024-11-28T14:59:00Z

PR for the documentation prebid/prebid.github.io#5742

* Accept all three params simultaneously * Fix bidder url

Sync upstream master

adapters/ogury/ogury.go

github-actions · 2024-11-28T14:59:48Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, cfc66d0

ogury

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:28:	MakeRequests		75.7%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:119:	filterValidImps		92.9%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:149:	getAdUnitCode		87.5%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:164:	setHeaders		57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:176:	getMediaTypeForBid	57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:196:	MakeBids		70.0%
total:								(statements)		75.8%

github-actions · 2024-11-29T08:47:56Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 1125795

ogury

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:26:	MakeRequests		75.7%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:117:	filterValidImps		92.9%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:147:	getAdUnitCode		87.5%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:162:	setHeaders		57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:174:	getMediaTypeForBid	57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:194:	MakeBids		70.0%
total:								(statements)		75.5%

krdzo · 2024-12-03T10:23:12Z

Hello I have a question with this PR.
We are using adUnitCode in our backend and I wanted to read it from imp[].Ext.Prebid.AdUnitCode but I see that this field is not forwarded to bidders (also opened this issue #4077 to see if this is a bug or intended behaviour), so we using imp.Id as a fallback for adunitcode.
Is this a right assumption, can we relay on imp[].id to always have adUnitCode?

always use imp.id for adunitcode, to map to imp.tagid

github-actions · 2024-12-11T11:10:30Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2289c6c

ogury

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:25:	MakeRequests		74.3%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:113:	filterValidImps		92.9%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:143:	setHeaders		57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:155:	getMediaTypeForBid	57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:175:	MakeBids		70.0%
total:								(statements)		73.8%

SyntaxNode · 2024-12-12T21:56:23Z

static/bidder-info/ogury.yaml

+  - global
+maintainer:
+  email: [email protected]
+gvlVendorID: 31


Verified GVL ID.

adapters/ogury/ogury.go

SyntaxNode · 2024-12-12T22:15:48Z

Hello I have a question with this PR. We are using adUnitCode in our backend and I wanted to read it from imp[].Ext.Prebid.AdUnitCode but I see that this field is not forwarded to bidders (also opened this issue #4077 to see if this is a bug or intended behaviour), so we using imp.Id as a fallback for adunitcode. Is this a right assumption, can we relay on imp[].id to always have adUnitCode?

Let's leave the discussion on the mentioned issue.

* use jsonutil package instead standard json lib * don't allocate newImpExt, use impExt for hoisting bidder.params * rename to buildHeader * set IPv6 header * use mtype from response

github-actions · 2024-12-13T14:07:21Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 119a517

ogury

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:26:	MakeRequests		71.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:106:	filterValidImps		92.9%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:136:	buildHeaders		50.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:149:	getMediaTypeForBid	33.3%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:166:	MakeBids		70.0%
total:								(statements)		70.0%

krdzo · 2024-12-16T08:09:04Z

@SyntaxNode I pushed changes to address comments on PR
Can you take a look again at it?

krdzo added 8 commits November 4, 2024 09:09

New Adapter: Ogury

f26eff9

New Adapter: Ogury - fix tests

a7b2104

New Adapter: Ogury - fix url

ec83b52

* Accept all three params simultaneously * Fix bidder url

New Adapter: Ogury - Fix user sync url

0eaa327

add text params

3a6c990

Merge remote-tracking branch 'origin/master' into sync-upstream-master

c4d6496

Merge pull request #8 from Ogury/sync-upstream-master

57fe53a

Sync upstream master

* New Adapter: Ogury - filter imps

cfc66d0

github-actions bot reviewed Nov 28, 2024

View reviewed changes

adapters/ogury/ogury.go Outdated Show resolved Hide resolved

krdzo mentioned this pull request Nov 29, 2024

ADV-20406 fix for prebid pr commnet Ogury/prebid-server#10

Merged

change oguryAdapter to adapter

1125795

krdzo mentioned this pull request Nov 29, 2024

Ogury adapter: set pbs to true prebid/prebid.github.io#5742

Open

2 tasks

krdzo mentioned this pull request Dec 11, 2024

Add adUnitCode to the imp.ext.prebid exception list #4077

Open

remove adunitcode mapping

2289c6c

always use imp.id for adunitcode, to map to imp.tagid

SyntaxNode reviewed Dec 12, 2024

View reviewed changes

ADV-20406 address pr comments (#12)

119a517

* use jsonutil package instead standard json lib * don't allocate newImpExt, use impExt for hoisting bidder.params * rename to buildHeader * set IPv6 header * use mtype from response

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: Ogury #4082

New Adapter: Ogury #4082

krdzo commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 29, 2024

krdzo commented Dec 3, 2024

github-actions bot commented Dec 11, 2024

SyntaxNode Dec 12, 2024

SyntaxNode commented Dec 12, 2024

github-actions bot commented Dec 13, 2024

krdzo commented Dec 16, 2024

New Adapter: Ogury #4082

Are you sure you want to change the base?

New Adapter: Ogury #4082

Conversation

krdzo commented Nov 28, 2024 • edited Loading

github-actions bot commented Nov 28, 2024

Code coverage summary

ogury

github-actions bot commented Nov 29, 2024

Code coverage summary

ogury

krdzo commented Dec 3, 2024

github-actions bot commented Dec 11, 2024

Code coverage summary

ogury

SyntaxNode Dec 12, 2024

Choose a reason for hiding this comment

SyntaxNode commented Dec 12, 2024

github-actions bot commented Dec 13, 2024

Code coverage summary

ogury

krdzo commented Dec 16, 2024

krdzo commented Nov 28, 2024 •

edited

Loading