New Adapter: AdUp Tech #4076
New Adapter: AdUp Tech #4076
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) { | ||
| switch markupType { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
| } | ||
|
|
||
| func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) { | ||
| switch markupType { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
Code coverage summaryNote:
aduptechRefer here for heat map coverage report |
danygielow
force-pushed
the
feat/add-aduptech-adapter
branch
from
74112fe to
8e94b4b
Compare
| } | ||
|
|
||
| func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) { | ||
| switch markupType { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
| } | ||
|
|
||
| func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) { | ||
| switch markupType { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
Code coverage summaryNote:
aduptechRefer here for heat map coverage report |
Hello,
We as AdUp Technology want to add our own Prebid Server Adapter.
We already have a PrebidJS Adapter.
Docs: prebid/prebid.github.io#5728