Remove Default Request Hardcoded Aliases #4020
Conversation
| @@ -151,6 +137,8 @@ type platform struct { | |||
| func mapDetailFromConfig(c config.BidderInfo) bidderDetail { | |||
| var bidderDetail bidderDetail | |||
|
|
|||
| bidderDetail.AliasOf = c.AliasOf | |||
There was a problem hiding this comment.
Fixes an unreported bug where hardcoded aliases are not marked as such in the bidder info endpoints.
SyntaxNode
changed the title
router/router.go
Outdated
| if len(errs) > 0 { | ||
| return errortypes.NewAggregateError("default request alias errors", errs) | ||
| if err := jsonutil.UnmarshalValid(defaultRequestJSON, &openrtb2model.BidRequest{}); err != nil { | ||
| // we might not have aliases defined, but will at least show that the JSON file is parsable. |
There was a problem hiding this comment.
Nitpick: is this comment still relevant?
There was a problem hiding this comment.
This snippet (https://github.com/prebid/prebid-server/blob/master/endpoints/openrtb2/auction.go#L1673-L1689) is still relevant right? We still need to do this merge of the incoming request with the default request. Aliases on the default request defined at req.ext.prebid.aliases are merged as part of this process but they are considered request aliases rather than hardcoded aliases.
There was a problem hiding this comment.
Yes. That's merging in the default stored request, not specific to aliases. Not sure why the comments are indicating as such. Changing the code to not be alias specific.
@hhhjort you originally wrote this, any idea?
| name: "mixed", | ||
| givenBidders: config.BidderInfos{"a": disabledCore, "b": disabledAlias, "c": enabledCore, "d": enabledAlias}, | ||
| expected: `["a","b","c","d"]`, |
There was a problem hiding this comment.
I think you can delete this test case. It is the same as the alias-many-mixed case on lines 57-59.
endpoints/info/bidders_test.go
Outdated
| { | ||
| name: "mixed", | ||
| givenBidders: config.BidderInfos{"a": disabledCore, "b": disabledAlias, "c": enabledCore, "d": enabledAlias}, | ||
| expected: `["a","c"]`, | ||
| }, |
There was a problem hiding this comment.
I think you can delete this test case. It is the same as the alias-mixed case on lines 126-128.
| name: "mixed", | ||
| givenBidders: config.BidderInfos{"a": disabledCore, "b": disabledAlias, "c": enabledCore, "d": enabledAlias}, | ||
| expected: `["c","d"]`, |
There was a problem hiding this comment.
I think you can delete this test case. It is the same as the alias-mixed case on lines 190-192.
As we move to the next major Prebid Server release, it's time to remove legacy behavior where hardcoded aliases were "promoted" from the default request to the server level.
Support for hardcoded request aliases has been fully implemented in Prebid Server for a while. The legacy approach was a quick way to provide a limited ability for hardcoded aliases. Now that we have the full implementation, it's time for this to go.
If you are host currently using this feature you will need to add a yaml file defining the alias instead for the alias to appear in the server bidder list. Aliases defined in the default request will continue to work as normal request level aliases without change.