New Adapter: TradPlus #3987
Open
New Adapter: TradPlus #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Code coverage summaryNote:
tradplusRefer here for heat map coverage report |
Code coverage summaryNote:
tradplusRefer here for heat map coverage report |
SyntaxNode
reviewed
Oct 24, 2024
adapters/tradplus/tradplustest/exemplary/simple-native-1.1.json
Outdated
Show resolved
Hide resolved
|
|
||
| func (a *adapter) makeRequest(request *openrtb2.BidRequest) (*adapters.RequestData, []error) { | ||
|
|
||
| tradplusExt, err := getImpressionExt(&request.Imp[0]) |
There was a problem hiding this comment.
Please link to your prebid.github.io PR and make it clear in that PR that the TradPlus only looks at the ext for the first impression and ignored the rest. Some other adapters do it, but its not a publisher expected behavior.
There was a problem hiding this comment.
ok，I've added to the first comment if anything else is needed ?
There was a problem hiding this comment.
Yes. New adapters must also open a PR against the Prebid Docs repository here: https://github.com/prebid/prebid.github.io/
Please see the User Documentation section of our new adapter developer guide.
There was a problem hiding this comment.
Follow up question: adapter code takes imp[0].ext and uses it to build endpoint url. Then sets imp[0].ext to nil, L49: request.Imp[0].Ext = nil
Other impressions are passed as is, with imp[n].ext.
Is this expected? Do you want to set every imp[n].ext to nil?
Code coverage summaryNote:
tradplusRefer here for heat map coverage report |
|
@SyntaxNode , hi, I have changed these codes，please review these codes. |
Code coverage summaryNote:
tradplusRefer here for heat map coverage report |
Code coverage summaryNote:
tradplusRefer here for heat map coverage report |
|
@SyntaxNode I re-merged from master. |
Code coverage summaryNote:
tradplusRefer here for heat map coverage report |
Code coverage summaryNote:
tradplusRefer here for heat map coverage report |
Code coverage summaryNote:
tradplusRefer here for heat map coverage report |
Code coverage summaryNote:
tradplusRefer here for heat map coverage report |
Code coverage summaryNote:
tradplusRefer here for heat map coverage report |
Code coverage summaryNote:
tradplusRefer here for heat map coverage report |
adapters/tradplus/tradplus.go
Outdated
Comment on lines
87
to
91
| if tradplusExt.AccountID == "" { | ||
| return nil, &errortypes.BadInput{ | ||
| Message: "imp.ext.accountId required", | ||
| } | ||
| } |
There was a problem hiding this comment.
This check is not needed here. It's handled by PBS core using properties set up:
"accountId": {
"type": "string",
"description": "Account ID",
"minLength": 1
},and
"required": [
"accountId"
]
Code coverage summaryNote:
tradplusRefer here for heat map coverage report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TradPlus is a leading, stable, and reliable ad monetization platform that is committed to providing global developers with fair, transparent and efficient monetization solutions. We also provide ADX and Saas ADX services. We serve 2,000+ global developers. Moreover, Our SDK has been certified by IAB Tech Lab and also joins Google Play SDK Index. And we have Information Security Management Certification.
Our advertising business spans the world. This is our official website: https://tradplusad.com/en. You can get more details about TradPlus.
this is TradPlus adapter version 1.0.
Thank!
Note: TradPlus only looks at the ext for the first impression and ignored the rest.