Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: single bid processing from alternatebiddercode #3313

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Fix: single bid processing from alternatebiddercode #3313

merged 1 commit into from
Dec 4, 2023

Conversation

ashishshinde-pubm
Copy link
Contributor

@ashishshinde-pubm ashishshinde-pubm commented Nov 23, 2023 •
edited
Loading

In alternatebiddercodes feature (#2174) it it possible that prebid-server gets a bid only from alternatebidder and not the primary bidder. Ex. For PubMatic-GroupM setup, PubMatic adapter would return a GroupM bid only.

For the above scenario,

  1. L769 , extraRespInfo.bidsFound is set to 'false' because 'brw.bidder' is 'pubmatic' but seatBid.Seat is 'groupm'
  2. L377, anyBidsReturned flag is set to false .
  3. if anyBidsReturned=false then Floor-enforcement + category-mapping + deal-support etc are not being applied to the bid-response.Even targetting-keys + event-trackers are missing in the bid.ext

This PR contains the fix for the issue, also to capture such issue I've introduced the unit-test case to cover 'getallbids' function. Currently only addressed the required scenarions in the test function but it can be extended in future as per requirement.

Refer - sample_request.txt

@ashishshinde-pubm ashishshinde-pubm changed the title Fix extraRespInfo.bidsFound flag in case of alternatebiddercode feature returning single bid fix: single bid processing from alternatebiddercode Nov 23, 2023
@ashishshinde-pubm ashishshinde-pubm marked this pull request as ready for review November 23, 2023 11:08
@bsardo bsardo changed the title fix: single bid processing from alternatebiddercode Fix: single bid processing from alternatebiddercode Nov 27, 2023
VeronikaSolovei9
VeronikaSolovei9 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@VeronikaSolovei9 VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo assigned AlexBVolcy and unassigned bsardo Nov 30, 2023
@bsardo bsardo merged commit 4de96b2 into prebid:master Dec 4, 2023
3 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Dec 4, 2023
Closed
SuprPhatAnon pushed a commit to GiftConnect/prebid-server that referenced this pull request Dec 7, 2023
@ashishshinde-pubm @SuprPhatAnon
Fix: single bid processing from alternatebiddercode (prebid#3313)
158d9ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexBVolcy AlexBVolcy AlexBVolcy approved these changes

@VeronikaSolovei9 VeronikaSolovei9 VeronikaSolovei9 approved these changes

Assignees

@VeronikaSolovei9 VeronikaSolovei9

@AlexBVolcy AlexBVolcy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashishshinde-pubm @VeronikaSolovei9 @AlexBVolcy @bsardo