seedingAlliance: make suntContent alias, add finative alias and add seatId bidder param in seedingAlliance #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sag-henmus
commented
Nov 20, 2023
sag-henmus
commented
- remove suntContent adapter, as it is practically a copy of the seedingAlliance code, and add as alias to seedingAlliance
- add "seatId" as bidder param for seedingAlliance, to make endpoint configurable
- suntContent was used in chooser_test.go for case insensitivity check, substitute with seedingAlliance
Code coverage summaryNote:
seedingAllianceRefer here for heat map coverage report |
onkarvhanumante
assigned onkarvhanumante, Sonali-More-Xandr and gargcreation1992 and unassigned Sonali-More-Xandr
| endpoint: "https://b.nativendo.de/cds/rtb/bid?ssp=pbs" | ||
| endpoint: "https://b.nativendo.de/cds/rtb/bid?ssp={{.AccountID}}" |
There was a problem hiding this comment.
@sag-henmus could you explain usage of account id.
Based on account id will request get directed to bidder server hosted in different regions?
There was a problem hiding this comment.
@sag-henmus could you explain usage of
account id.Based on account id will request get directed to bidder server hosted in different regions?
@sag-henmus requesting to address above comment
There was a problem hiding this comment.
@onkarvhanumante no, this is used as optional identifier for SSPs with a special agreement with us who want to use our adapter.
onkarvhanumante
changed the title
|
should update json tests to use updated prebid-server/adapters/seedingAlliance/seedingAlliance_test.go Lines 15 to 17 in ec729e6 |
Code coverage summaryNote:
seedingAllianceRefer here for heat map coverage report |
onkarvhanumante
previously approved these changes
Nov 28, 2023
| @@ -1,4 +1,4 @@ | |||
| endpoint: "https://b.nativendo.de/cds/rtb/bid?ssp=pbs" | |||
| endpoint: "https://b.nativendo.de/cds/rtb/bid?ssp={{.AccountID}}" | |||
| maintainer: | |||
| email: [email protected] | |||
There was a problem hiding this comment.
Sent an email for verification. Please reply with received.
Code coverage summaryNote:
seedingAllianceRefer here for heat map coverage report |
gargcreation1992
approved these changes
Dec 7, 2023
onkarvhanumante
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.