Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Flag for Host to Enabled/Disable Bidder from Usersync #3285

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Add Flag for Host to Enabled/Disable Bidder from Usersync #3285

merged 6 commits into from
Dec 5, 2023

Conversation

AlexBVolcy
Copy link
Contributor

@AlexBVolcy AlexBVolcy commented Nov 7, 2023 •
edited
Loading

Addresses this issue: #2573

@AlexBVolcy AlexBVolcy marked this pull request as ready for review November 16, 2023 23:56
@bsardo bsardo self-assigned this Nov 20, 2023
VeronikaSolovei9
VeronikaSolovei9 reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@VeronikaSolovei9 VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comments, local testing looks good

usersync/chooser_test.go Outdated Show resolved Hide resolved
config/bidderinfo.go Outdated Show resolved Hide resolved
endpoints/cookie_sync.go Outdated Show resolved Hide resolved
VeronikaSolovei9
VeronikaSolovei9 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@VeronikaSolovei9 VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo assigned guscarreon and unassigned bsardo Nov 30, 2023
guscarreon
guscarreon approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@guscarreon guscarreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo merged commit 8128b24 into prebid:master Dec 5, 2023
3 checks passed
SuprPhatAnon pushed a commit to GiftConnect/prebid-server that referenced this pull request Dec 7, 2023
@AlexBVolcy @SuprPhatAnon
Add Flag for Host to Enabled/Disable Bidder from Usersync (prebid#3285)
e71cad2
@AlexBVolcy AlexBVolcy mentioned this pull request Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guscarreon guscarreon guscarreon approved these changes

@VeronikaSolovei9 VeronikaSolovei9 VeronikaSolovei9 approved these changes

Assignees

@VeronikaSolovei9 VeronikaSolovei9

@guscarreon guscarreon

Labels
do not port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexBVolcy @VeronikaSolovei9 @guscarreon @bsardo @SyntaxNode