-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonobi: Added consent macros to the user sync url #3283
Conversation
url: "https://sync.go.sonobi.com/us.gif?loc={{.RedirectURL}}" | ||
url: "https://sync.go.sonobi.com/us.gif?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&loc={{.RedirectURL}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonGoSonobi refer following cases where user sync url was not redirecting back
not working:
https://sync.go.sonobi.com/us.gif?gdpr=1&gdpr_consent=0&us_privacy=0&loc=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dsonobi%26gdpr%3D%26gdpr_consent%3D%26f%3Di%26uid%3D%5BUID%5D
https://sync.go.sonobi.com/us.gif?gdpr=1&gdpr_consent=0&us_privacy=1&loc=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dsonobi%26gdpr%3D%26gdpr_consent%3D%26f%3Di%26uid%3D%5BUID%5D
https://sync.go.sonobi.com/us.gif?gdpr=1&gdpr_consent=1&us_privacy=0&loc=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dsonobi%26gdpr%3D%26gdpr_consent%3D%26f%3Di%26uid%3D%5BUID%5D
https://sync.go.sonobi.com/us.gif?gdpr=1&gdpr_consent=1&us_privacy=1&loc=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dsonobi%26gdpr%3D%26gdpr_consent%3D%26f%3Di%26uid%3D%5BUID%5D
working:
https://sync.go.sonobi.com/us.gif?gdpr=0&gdpr_consent=0&us_privacy=1&loc=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dsonobi%26gdpr%3D%26gdpr_consent%3D%26f%3Di%26uid%3D%5BUID%5D
https://sync.go.sonobi.com/us.gif?gdpr=0&gdpr_consent=1&us_privacy=0&loc=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dsonobi%26gdpr%3D%26gdpr_consent%3D%26f%3Di%26uid%3D%5BUID%5D
https://sync.go.sonobi.com/us.gif?gdpr=0&gdpr_consent=1&us_privacy=1&loc=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dsonobi%26gdpr%3D%26gdpr_consent%3D%26f%3Di%26uid%3D%5BUID%5D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonGoSonobi could you address above comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonGoSonobi ping to address above PR comments
@JonGoSonobi Requesting you to please address the open comment. |
@JonGoSonobi closing this PR due to inactivity. PR can be reopened when new changes are pushed on sonobi:sonobi-add-consent-to-usersyncs |
Hey @onkarvhanumante, I reviewed this over with the team. The sync urls that fail to redirect is because the gdpr_consent string provided does not define that Sonobi is consented to user snyc. So, the endpoint will not redirect to the &loc query parameter. Should our user sync endpoint redirect even if the gdpr_consent string doesnt say Sonobi is consented? |
@onkarvhanumante any chance you were able to look at my last comment? I'll re-open this PR if this thread has gone stale. |
Updated Sonobi's user sync endpoint to fill the gdpr and us privacy query params