HuaweiAds: Increase fill rate for native ads #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetfaruk59
changed the title
Code coverage summaryNote:
huaweiadsRefer here for heat map coverage report |
ahmetfaruk59
changed the title
ahmetfaruk59
changed the title
|
@bretg @onkarvhanumante Hi, hope you doing ok. Could you check here please? |
|
@ahmetfaruk59 - this will go through the normal review assignment process. |
Thanks @bretg. And when is it reviewed and merged? I thought the server is updated weekly. It was a bit of an urgent development. |
Code coverage summaryNote:
huaweiadsRefer here for heat map coverage report |
@ahmetfaruk59 Thank you for keeping patience with us. Reviewer are assigned to review PR |
Comment on lines
+568
to
+573
| if numFormat == 1 && asset.Img.H != 0 && asset.Img.W != 0 && asset.Img.WMin != 0 && asset.Img.HMin != 0 { | ||
| result := filterPopularSizes(popularSizes, asset.Img.W, asset.Img.H, "ratio") | ||
| for i := 0; i < len(result); i++ { | ||
| formats = append(formats, format{result[i]["w"], result[i]["h"]}) | ||
| } | ||
| } |
There was a problem hiding this comment.
should add json framework test to cover above code path
There was a problem hiding this comment.
Hi @onkarvhanumante , thanks for all feedbacks and review 🙌 It's updated.
There was a problem hiding this comment.
thanks @ahmetfaruk59
could you link jsontest where numFormatcount is 1 and asset.Img.W is 0 and asset.Img.H is 0
If jsontest is not available then should add one for above scenario
There was a problem hiding this comment.
thanks @onkarvhanumante . actually nativeThreeImageIncludeIcon test file covers this scenario but i added a new test file only this case in last commit. thanks again for your feedback 🙌
Code coverage summaryNote:
huaweiadsRefer here for heat map coverage report |
Code coverage summaryNote:
huaweiadsRefer here for heat map coverage report |
Code coverage summaryNote:
huaweiadsRefer here for heat map coverage report |
onkarvhanumante
approved these changes
Nov 13, 2023
Sonali-More-Xandr
approved these changes
Nov 13, 2023
|
Hi @bretg , hope you are ok. I thought this PR would automatically merged for version 2.0.2. It is a bit urgent. Can we get this merged? Thanks a lot. |
Thanks for keeping patience with us. PR merged |
Thanks a lot, i appreciated. |
svamiftah
pushed a commit
to sovrn/prebid-server
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the size of the requested ad, filter popular sizes and bind it to the request as multiple format.