Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: oms #3264

Merged
merged 3 commits into from
Nov 20, 2023
Merged

New Adapter: oms #3264

merged 3 commits into from
Nov 20, 2023

Conversation

m6yf
Copy link
Contributor

@m6yf m6yf commented Oct 28, 2023

Golang code (including tests) for Online media solutions(OMS) server adaptor.

github-actions[bot]
github-actions bot reviewed Oct 28, 2023
View reviewed changes
adapters/oms/oms.go Outdated
var bidExt openrtb_ext.ExtBid
err := json.Unmarshal(bid.Ext, &bidExt)
if err == nil && bidExt.Prebid != nil {
return openrtb_ext.ParseBidType(string(bidExt.Prebid.Type))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m6yf requesting to address above comment

Copy link
Contributor Author

@m6yf m6yf Nov 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onkarvhanumante thanks for the feedback and sorry for late response.
I accept your suggestion, since we support only banners at the moment I've changed it to place the literal :


for _, seatBid := range response.SeatBid {
		for i := range seatBid.Bid {
			bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{
				Bid:     &seatBid.Bid[i],
				BidType: openrtb_ext.BidTypeBanner,
			})
		}
	}

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4961ac5

oms

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/oms/oms.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/oms/oms.go:26:	MakeRequests		80.0%
github.com/prebid/prebid-server/v2/adapters/oms/oms.go:41:	getMediaTypeForBid	83.3%
github.com/prebid/prebid-server/v2/adapters/oms/oms.go:55:	MakeBids		86.4%
total:								(statements)		85.7%

onkarvhanumante
onkarvhanumante reviewed Nov 2, 2023
View reviewed changes
static/bidder-info/oms.yaml
@@ -0,0 +1,11 @@
endpoint: "http://rt.marphezis.com/pbs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint is reachable

onkarvhanumante
onkarvhanumante reviewed Nov 2, 2023
View reviewed changes
adapters/oms/oms.go Outdated Show resolved Hide resolved
onkarvhanumante
onkarvhanumante reviewed Nov 2, 2023
View reviewed changes
adapters/oms/oms.go Outdated Show resolved Hide resolved
onkarvhanumante
onkarvhanumante reviewed Nov 2, 2023
View reviewed changes
adapters/oms/oms.go Outdated Show resolved Hide resolved
@onkarvhanumante
Copy link
Contributor

@m6yf should open docs PR in https://github.com/prebid/prebid.github.io repo

docs pr helps publishers to prepare request for adapters

@muuki88
Copy link

muuki88 commented Nov 2, 2023

Related docs PR: prebid/prebid.github.io#4954

@muuki88 muuki88 mentioned this pull request Nov 2, 2023
Merged
8 tasks
@onkarvhanumante
Copy link
Contributor

@m6yf requesting to address PR comments

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c1eaced

oms

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/oms/oms.go:19:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/oms/oms.go:26:	MakeRequests	80.0%
github.com/prebid/prebid-server/v2/adapters/oms/oms.go:41:	MakeBids	94.1%
total:								(statements)	91.7%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 992de01

oms

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/oms/oms.go:19:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/oms/oms.go:26:	MakeRequests	80.0%
github.com/prebid/prebid-server/v2/adapters/oms/oms.go:41:	MakeBids	94.4%
total:								(statements)	92.0%

onkarvhanumante
onkarvhanumante reviewed Nov 16, 2023
View reviewed changes
static/bidder-info/oms.yaml
@@ -0,0 +1,11 @@
endpoint: "http://rt.marphezis.com/pbs"
maintainer:
email: "[email protected]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m6yf Prebid team has sent an verification email on above address. Requesting to respond email with "received" message

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

received response from OMS

@Sonali-More-Xandr Sonali-More-Xandr merged commit 01f3320 into prebid:master Nov 20, 2023
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Nov 20, 2023
Closed
svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023
@m6yf @yfcr @svamiftah
New Adapter: oms (prebid#3264)
8114ba6 
Co-authored-by: yfcr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Sonali-More-Xandr Sonali-More-Xandr Sonali-More-Xandr approved these changes

@onkarvhanumante onkarvhanumante onkarvhanumante approved these changes

Assignees

@onkarvhanumante onkarvhanumante

@Sonali-More-Xandr Sonali-More-Xandr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@m6yf @onkarvhanumante @muuki88 @Sonali-More-Xandr @yfcr