IX: add privacy sandbox support #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
ixRefer here for heat map coverage report |
bsardo
changed the title
adapters/ix/ix.go
Outdated
| @@ -19,7 +19,8 @@ import ( | |||
| ) | |||
|
|
|||
| type IxAdapter struct { | |||
| URI string | |||
| URI string | |||
| bidderName string | |||
There was a problem hiding this comment.
@ccorbo could you help to understand how adding bidderName facilates privacy sandbox support
There was a problem hiding this comment.
Removed bidderName - not needed
There was a problem hiding this comment.
Removed bidderName - not needed
@ccorbo could you link commit where bidderName is removed. PR diff still has bidderName
There was a problem hiding this comment.
whoops sorry - updated now
adapters/ix/ix.go
Outdated
| @@ -273,6 +283,23 @@ func (a *IxAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externalReque | |||
| } | |||
| } | |||
|
|
|||
| if bidResponse.Ext != nil { | |||
| var bidRespExt ixRespExt | |||
| if err := json.Unmarshal(bidResponse.Ext, &bidRespExt); err == nil && bidRespExt.AuctionConfig != nil { | |||
There was a problem hiding this comment.
should not ignore unMarshal error. This could be a potential bad bidder server issue
|
@ccorbo Please take a look at the above comments/questions. |
ccorbo
force-pushed
the
fledge_PB-1925
branch
from
b9d0090 to
14e5e72
Compare
Code coverage summaryNote:
ixRefer here for heat map coverage report |
adapters/ix/ix.go
Outdated
Comment on lines
288
to
303
| if err := json.Unmarshal(bidResponse.Ext, &bidRespExt); err == nil && bidRespExt.AuctionConfig != nil { | ||
| bidderResponse.FledgeAuctionConfigs = make([]*openrtb_ext.FledgeAuctionConfig, 0, len(bidRespExt.AuctionConfig)) | ||
| for _, config := range bidRespExt.AuctionConfig { | ||
| if config.Config != nil { | ||
| fledgeAuctionConfig := &openrtb_ext.FledgeAuctionConfig{ | ||
| ImpId: config.BidId, | ||
| Config: config.Config, | ||
| } | ||
| bidderResponse.FledgeAuctionConfigs = append(bidderResponse.FledgeAuctionConfigs, fledgeAuctionConfig) | ||
| } | ||
| } | ||
| } else { | ||
| if err != nil { | ||
| errs = append(errs, err) | ||
| } | ||
| } |
There was a problem hiding this comment.
above block can be rewritten as below for better readability
if bidResponse.Ext != nil {
var bidRespExt ixRespExt
if err := json.Unmarshal(bidResponse.Ext, &bidRespExt); err != nil {
return nil, append(errs, err)
}
if bidRespExt.AuctionConfig != nil {
bidderResponse.FledgeAuctionConfigs = make([]*openrtb_ext.FledgeAuctionConfig, 0, len(bidRespExt.AuctionConfig))
for _, config := range bidRespExt.AuctionConfig {
if config.Config != nil {
fledgeAuctionConfig := &openrtb_ext.FledgeAuctionConfig{
ImpId: config.BidId,
Config: config.Config,
}
bidderResponse.FledgeAuctionConfigs = append(bidderResponse.FledgeAuctionConfigs, fledgeAuctionConfig)
}
}
}
}
Code coverage summaryNote:
ixRefer here for heat map coverage report |
onkarvhanumante
approved these changes
Nov 21, 2023
Sonali-More-Xandr
approved these changes
Nov 23, 2023
SuprPhatAnon
pushed a commit
to GiftConnect/prebid-server
that referenced
this pull request
Dec 7, 2023
Co-authored-by: Chris Corbo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds privacy sandbox support to the IX Bid Adapter