Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Update #3246

Merged
merged 47 commits into from
Jan 17, 2024
Merged

Readme Update #3246

merged 47 commits into from
Jan 17, 2024

Conversation

SyntaxNode
Copy link
Contributor

@SyntaxNode SyntaxNode commented Oct 21, 2023

Major update to the README for Prebid Server 2.0.

Also includes initial improvements to the configuration doc at lease for the GDPR default value. Please let me know what you think of this config format and if you have any other suggestions.

Addresses: #1897

README.md Outdated

Or better yet, [open a pull request](https://github.com/prebid/prebid-server/compare) with the changes you'd like to see.
### Auction Module
Auction Modules allow hosts to extend the behavior of Prebid Server at specfic spots in the auction pipeline using existing modules or by developing custom functionality. Auction Modules may provide creative validation, traffic optimization, and real time data services amoung many other potential uses. We welcome vendors and community members to contribute modules that publishers and hosts may find useful. Consult our gude on [building an auction module](https://docs.prebid.org/prebid-server/developers/add-a-module.html) for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Gude --> Guide

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

docs/developers/configuration.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
First install [Go](https://golang.org/doc/install) version 1.19 or newer.
For deploying a fork, you can create a custom Docker container using the command:
``` bash
docker build -t prebid-server .
Copy link
Contributor

@zhongshixi zhongshixi Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SyntaxNode I would suggest adding a note before we refactor the image into a state that is also ARM-friendly.

so I would suggest explicitly adding --platform linux/amd64 as part of the docker build command

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circling back to this after the winter break. Is the use case building a deployment container on an Apple processor MacBook?

Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@SyntaxNode SyntaxNode merged commit fda9f06 into prebid:master Jan 17, 2024
3 checks passed
@SyntaxNode SyntaxNode deleted the readme_update branch January 17, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants