Adapter Name Case Insensitive: ext.prebid.multibid #3217
Conversation
| desc: "Lowercase prebid.MultiBid.Bidder is found in the BidderName list, entry is mapped", | ||
| inPrebid: &openrtb_ext.ExtRequestPrebid{ | ||
| MultiBid: []*openrtb_ext.ExtMultiBid{ | ||
| {Bidder: "appnexus"}, | ||
| }, | ||
| }, | ||
| expected: map[string]openrtb_ext.ExtMultiBid{ | ||
| "appnexus": {Bidder: "appnexus"}, | ||
| }, |
There was a problem hiding this comment.
Could you add another test case just like this, except the Bidder is capitalized: (i.e APPNEXUS)
| @@ -5750,3 +5750,182 @@ func TestSetSeatNonBid(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestBuildMultiBidMap(t *testing.T) { | |||
There was a problem hiding this comment.
Could you also a JSON test in /exchangetest similar to multi-bids.json, where we can test the case insensitivity there as well.
There was a problem hiding this comment.
Good catch! That extra test revealed another spot where case insensitivity was needed inside function buildRequestExtMultiBid(). Added exchange/exchangetest/multi-bids-mixed-case.json.
exchange/exchange_test.go
Outdated
| multiBidMap := buildMultiBidMap(tc.inPrebid) | ||
| assert.Equal(t, tc.expected, multiBidMap, tc.desc) |
| @@ -2259,8 +2259,13 @@ func TestTimeoutComputation(t *testing.T) { | |||
| func TestExchangeJSON(t *testing.T) { | |||
| if specFiles, err := os.ReadDir("./exchangetest"); err == nil { | |||
| for _, specFile := range specFiles { | |||
| if !strings.HasSuffix(specFile.Name(), ".json") { | |||
There was a problem hiding this comment.
Added so vim's .swp files wouldn't error. Can remove if you want
| @@ -467,12 +467,12 @@ func buildRequestExtMultiBid(adapter string, reqMultiBid []*openrtb_ext.ExtMulti | |||
| adapterMultiBid := make([]*openrtb_ext.ExtMultiBid, 0) | |||
| for _, multiBid := range reqMultiBid { | |||
| if multiBid.Bidder != "" { | |||
| if multiBid.Bidder == adapter || isBidderInExtAlternateBidderCodes(adapter, multiBid.Bidder, adapterABC) { | |||
| if strings.ToLower(multiBid.Bidder) == adapter || isBidderInExtAlternateBidderCodes(adapter, strings.ToLower(multiBid.Bidder), adapterABC) { | |||
There was a problem hiding this comment.
If we use openrtb_ext.NormalizeBidderName() here, exchange/exchangetest/multi-bids-with-extra-bids.json fails. Whether or not the expectations in said test are correct we can leave for a future discussion.
Normalization was done in
buildMultiBidMap(prebid *openrtb_ext.ExtRequestPrebid)inside fileexchange/exchange.go. Let me know your thoughts.