New Adapter: Relevant Digital #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This was referenced Oct 13, 2023
Code coverage summaryNote:
relevantdigitalRefer here for heat map coverage report |
hugolm84
force-pushed
the
hlindstrom/relevantDigitalBidAdapter
branch
from
58adafe to
ba3630e
Compare
Code coverage summaryNote:
relevantdigitalRefer here for heat map coverage report |
hugolm84
force-pushed
the
hlindstrom/relevantDigitalBidAdapter
branch
from
ba3630e to
7f1ed2a
Compare
Code coverage summaryNote:
relevantdigitalRefer here for heat map coverage report |
onkarvhanumante
changed the title
|
@hugolm84, |
hugolm84
force-pushed
the
hlindstrom/relevantDigitalBidAdapter
branch
from
7f1ed2a to
429745b
Compare
Thanks! Fixed. |
Code coverage summaryNote:
relevantdigitalRefer here for heat map coverage report |
|
@hugolm84 Please resolve the merge conflicts. |
hugolm84
force-pushed
the
hlindstrom/relevantDigitalBidAdapter
branch
from
429745b to
aa81755
Compare
Fixed :) |
Code coverage summaryNote:
relevantdigitalRefer here for heat map coverage report |
hugolm84
force-pushed
the
hlindstrom/relevantDigitalBidAdapter
branch
from
aa81755 to
82302e8
Compare
Code coverage summaryNote:
relevantdigitalRefer here for heat map coverage report |
hugolm84
force-pushed
the
hlindstrom/relevantDigitalBidAdapter
branch
from
82302e8 to
fc29c07
Compare
added 9 commits
November 28, 2023 20:13
hugolm84
force-pushed
the
hlindstrom/relevantDigitalBidAdapter
branch
from
d826904 to
ed8005b
Compare
Code coverage summaryNote:
relevantdigitalRefer here for heat map coverage report |
Thanks, this seems to be fixed now :) |
| @@ -0,0 +1,17 @@ | |||
| endpoint: "https://{{.Host}}.relevant-digital.com/openrtb2/auction" | |||
| maintainer: | |||
| email: "[email protected]" | |||
There was a problem hiding this comment.
I have sent an email to the above address again. Please reply with received.
|
Host looks like an optional param to me. Removing myself from the reviewer list. |
Hm, I might be missing something but doesnt the bidder-params specify what is required or not? Edit: Oh, I see now, the Host is the name of the param but its acquired like so: and bidder-params defines: |
|
@onkarvhanumante - please ensure that host is optional. Thanks! |
|
@hugolm84 ptal at #3216 (comment) comment |
|
@hugolm84 - I'm only involved in this because of the semi-dynamic host thing. That's resolved. Am removing myself from the reviewers list. |
gargcreation1992
approved these changes
Dec 5, 2023
onkarvhanumante
approved these changes
Dec 5, 2023
SuprPhatAnon
pushed a commit
to GiftConnect/prebid-server
that referenced
this pull request
Dec 7, 2023
co-authored by: @hugolm84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings Prebid team, I have the pleasure of submitting this adapter on
relevantdigitals behalf.This adapter is consistent with the .js adapter so please see previous documentation for
relevantdigitaljs adapter here: https://docs.prebid.org/dev-docs/bidders/relevantdigital.htmlThis PR is also dependant on the following PRs:
s2s support for .js adapter: prebid/Prebid.js#10610
s2s documentation: prebid/prebid.github.io#4931