Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeta Global SSP: Update endpoints #3201

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

abermanov-zeta
Copy link
Contributor

Get rid of shortname in bidding and user sync endpoints

endpoint: https://ssp.disqus.com/bid/prebid-server?sid=GET_SID_FROM_ZETA&shortname=GET_SHORTNAME_FROM_ZETA
endpoint: https://ssp.disqus.com/bid/prebid-server?sid=GET_SID_FROM_ZETA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abermanov-zeta please update json framework tests to use endpoints defined in bidder-info yaml. This ensures that adapter code is compatible with actual endpoint mentioned in yaml.

bidder, buildErr := Builder(openrtb_ext.BidderZetaGlobalSsp, config.Adapter{
Endpoint: "http://whatever.url"},
config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})
if buildErr != nil {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abermanov-zeta please update json framework tests to use endpoints defined in bidder-info yaml. This ensures that adapter code is compatible with actual endpoint mentioned in yaml.

bidder, buildErr := Builder(openrtb_ext.BidderZetaGlobalSsp, config.Adapter{
Endpoint: "http://whatever.url"},
config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})
if buildErr != nil {

@abermanov-zeta requesting to address comment to move forward with this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abermanov-zeta ping to address pending comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onkarvhanumante Sorry for the delay, I was on vacation. Tests have been updated. Thank you

@onkarvhanumante
Copy link
Contributor

@abermanov-zeta, prebid server has published major release 2.0.

Requesting to sync with abermanov-zeta:feature/endpoints_update with latest prebid server master.

Copy link

github-actions bot commented Nov 1, 2023

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6d74c3e

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:26:	MakeRequests		87.5%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:46:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:80:	getMediaTypeForBid	100.0%
total:											(statements)		94.3%

@bsardo bsardo changed the title Zeta Global SSP Bidder: update endpoints. Zeta Global SSP: Update endpoints Nov 16, 2023
@bsardo bsardo merged commit 79d2f27 into prebid:master Nov 16, 2023
5 checks passed
svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants