-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zeta Global SSP: Update endpoints #3201
Zeta Global SSP: Update endpoints #3201
Conversation
endpoint: https://ssp.disqus.com/bid/prebid-server?sid=GET_SID_FROM_ZETA&shortname=GET_SHORTNAME_FROM_ZETA | ||
endpoint: https://ssp.disqus.com/bid/prebid-server?sid=GET_SID_FROM_ZETA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abermanov-zeta please update json framework tests to use endpoints defined in bidder-info yaml. This ensures that adapter code is compatible with actual endpoint mentioned in yaml.
prebid-server/adapters/zeta_global_ssp/zeta_global_ssp_test.go
Lines 12 to 16 in 754a0eb
bidder, buildErr := Builder(openrtb_ext.BidderZetaGlobalSsp, config.Adapter{ | |
Endpoint: "http://whatever.url"}, | |
config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"}) | |
if buildErr != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abermanov-zeta please update json framework tests to use endpoints defined in bidder-info yaml. This ensures that adapter code is compatible with actual endpoint mentioned in yaml.
prebid-server/adapters/zeta_global_ssp/zeta_global_ssp_test.go
Lines 12 to 16 in 754a0eb
bidder, buildErr := Builder(openrtb_ext.BidderZetaGlobalSsp, config.Adapter{ Endpoint: "http://whatever.url"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"}) if buildErr != nil {
@abermanov-zeta requesting to address comment to move forward with this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abermanov-zeta ping to address pending comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onkarvhanumante Sorry for the delay, I was on vacation. Tests have been updated. Thank you
@abermanov-zeta, prebid server has published major release 2.0. Requesting to sync with |
Code coverage summaryNote:
zeta_global_sspRefer here for heat map coverage report
|
Get rid of
shortname
in bidding and user sync endpoints