New Adapter: IQX #3164

IQzoneIT · 2023-09-29T08:59:06Z

Dev-docs PR: prebid/prebid.github.io#4902

github-actions · 2023-09-29T08:59:56Z

adapters/iqx/iqx.go

+				continue
+			}
+
+			bidType, err := openrtb_ext.ParseBidType(bidExt.Prebid.Type)


Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

@IQzoneIT requesting to address above comment

github-actions · 2023-09-29T09:00:12Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 561edec

iqx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/iqx/iqx.go:29:		Builder				80.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:42:		buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:65:		MakeRequests			89.5%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:102:	MakeBids			100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:131:	prepareBidResponse		85.7%
total:								(statements)			91.4%

github-actions · 2023-09-29T09:01:46Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a427c32

iqx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/iqx/iqx.go:29:		Builder				80.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:42:		buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:65:		MakeRequests			89.5%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:102:	MakeBids			100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:131:	prepareBidResponse		85.7%
total:								(statements)			91.4%

adapters/iqx/iqx.go

onkarvhanumante · 2023-10-03T06:03:14Z

static/bidder-params/iqx.json

+    },
+    "pid": {
+      "type": "string",
+      "description": "Uniq placement ID",


typo in Uniq. Should be Unique

onkarvhanumante · 2023-10-03T06:42:51Z

static/bidder-info/iqx.yaml

@@ -0,0 +1,19 @@
+endpoint: "http://rtb.iqzone.com/?pid={{.SourceId}}&host={{.Host}}&pbs=1"


any specific reason to add / before query params ?. Following should also work

endpoint: "http://rtb.iqzone.com?pid={{.SourceId}}&host={{.Host}}&pbs=1"

github-actions · 2023-10-03T08:27:49Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, d998080

iqx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/iqx/iqx.go:29:		Builder				80.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:42:		buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:65:		MakeRequests			89.5%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:102:	MakeBids			100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:131:	prepareBidResponse		85.7%
total:								(statements)			91.4%

Sonali-More-Xandr · 2023-10-03T12:00:28Z

exchange/adapter_builders.go

@@ -291,6 +292,7 @@ func newAdapterBuilders() map[openrtb_ext.BidderName]adapters.Builder {
 		openrtb_ext.BidderInteractiveoffers: interactiveoffers.Builder,
 		openrtb_ext.BidderInvibes:           invibes.Builder,
 		openrtb_ext.BidderIQZone:            iqzone.Builder,
+		openrtb_ext.BidderIQX:               iqx.Builder,


Nitpick :- this should be moved above openrtb_ext.BidderIQZone: iqzone.Builder,

Sonali-More-Xandr · 2023-10-03T12:04:36Z

static/bidder-info/iqx.yaml

@@ -0,0 +1,19 @@
+endpoint: "http://rtb.iqzone.com?pid={{.SourceId}}&host={{.Host}}&pbs=1"
+maintainer:
+  email: "[email protected]"


@IQzoneIT We have sent an email to [email protected] to verify the maintainer email address as part of the onboarding process. Please revert back to that email with "Received" message to complete the verification.

@Sonali-More-Xandr done

github-actions · 2023-10-03T12:16:27Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, d947591

iqx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/iqx/iqx.go:29:		Builder				80.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:42:		buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:65:		MakeRequests			89.5%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:102:	MakeBids			100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:131:	prepareBidResponse		85.7%
total:								(statements)			91.4%

onkarvhanumante · 2023-10-09T06:53:13Z

static/bidder-info/iqx.yaml

@@ -0,0 +1,19 @@
+endpoint: "http://rtb.iqzone.com?pid={{.SourceId}}&host={{.Host}}&pbs=1"


endpoint is reachable

onkarvhanumante · 2023-10-09T06:54:38Z

adapters/iqx/iqx.go

+					Message: fmt.Sprintf("Bid[%d].Ext.Prebid.Type expects one of the following values: 'banner', 'native', 'video', 'audio', got '%s'", bidId, bidExt.Prebid.Type),
+				})


As per static/bidder-info/iqx.yaml, audio is not supported by adapter. Should remove audio from error message

github-actions · 2023-10-09T07:35:08Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 8da02ed

iqx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/iqx/iqx.go:29:		Builder				80.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:42:		buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:65:		MakeRequests			89.5%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:102:	MakeBids			100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:131:	prepareBidResponse		85.7%
total:								(statements)			91.4%

IQzoneIT · 2023-10-09T08:20:54Z

@onkarvhanumante done

github-actions · 2023-10-09T08:21:18Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, ccf5358

iqx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/iqx/iqx.go:29:		Builder				80.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:42:		buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:65:		MakeRequests			89.5%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:102:	MakeBids			100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:131:	prepareBidResponse		100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:153:	getMediaTypeForBid		100.0%
total:								(statements)			94.9%

onkarvhanumante · 2023-10-09T12:51:46Z

adapters/iqx/iqx.go

+	case openrtb2.MarkupNative:
+		return openrtb_ext.BidTypeNative, nil
+	default:
+		return "", fmt.Errorf("failed to parse bid mType for impression \"%s\"", bid.ImpID)


if bid.ImpID is 2 then this will result in "failed to parse bid mType for impression \"2\". From this error message it is unclear whether 2 is mType value or index from imp array. How about refactoring error message to - failed to parse bid mtype for impression id \"2"\

@onkarvhanumante done

github-actions · 2023-10-10T09:01:31Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 7ed229a

iqx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/iqx/iqx.go:29:		Builder				80.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:42:		buildEndpointFromRequest	100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:65:		MakeRequests			89.5%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:102:	MakeBids			100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:131:	prepareBidResponse		100.0%
github.com/prebid/prebid-server/adapters/iqx/iqx.go:153:	getMediaTypeForBid		100.0%
total:								(statements)			94.9%

Co-authored-by: Dmytro Shyrokov <[email protected]>

iqx adapter init

561edec

github-actions bot reviewed Sep 29, 2023

View reviewed changes

iqx: setup live ep

a427c32

IQzoneIT changed the title ~~iqx adapter init~~ New Adapter: IQX Sep 29, 2023

IQzoneIT mentioned this pull request Sep 29, 2023

IQX bidder adapter docs init prebid/prebid.github.io#4902

Merged

1 task

gargcreation1992 assigned onkarvhanumante and Sonali-More-Xandr Sep 29, 2023

onkarvhanumante reviewed Oct 3, 2023

View reviewed changes

adapters/iqx/iqx.go Show resolved Hide resolved

onkarvhanumante reviewed Oct 3, 2023

View reviewed changes

onkarvhanumante code review

d998080

Sonali-More-Xandr reviewed Oct 3, 2023

View reviewed changes

Update adapter_builders.go

d947591

onkarvhanumante reviewed Oct 9, 2023

View reviewed changes

remove audio from mediatype err

8da02ed

bid MType support, getMediaTypeForBid

ccf5358

onkarvhanumante reviewed Oct 9, 2023

View reviewed changes

fix err wording

7ed229a

onkarvhanumante approved these changes Oct 13, 2023

View reviewed changes

Sonali-More-Xandr approved these changes Oct 19, 2023

View reviewed changes

Sonali-More-Xandr merged commit 8131a14 into prebid:master Oct 19, 2023
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Oct 19, 2023

Port PR from PBS-Go: New Adapter: IQX prebid/prebid-server-java#2714

Closed

svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023

New Adapter: IQX (prebid#3164)

73bd52c

Co-authored-by: Dmytro Shyrokov <[email protected]>

bold-win mentioned this pull request Jan 26, 2024

BoldwinX adapter docs prebid/prebid.github.io#5105

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: IQX #3164

New Adapter: IQX #3164

IQzoneIT commented Sep 29, 2023 •

edited

Loading

github-actions bot Sep 29, 2023

onkarvhanumante Oct 9, 2023

github-actions bot commented Sep 29, 2023

github-actions bot commented Sep 29, 2023

onkarvhanumante Oct 3, 2023

onkarvhanumante Oct 3, 2023

github-actions bot commented Oct 3, 2023

Sonali-More-Xandr Oct 3, 2023

Sonali-More-Xandr Oct 3, 2023

IQzoneIT Oct 4, 2023

github-actions bot commented Oct 3, 2023

onkarvhanumante Oct 9, 2023

onkarvhanumante Oct 9, 2023

github-actions bot commented Oct 9, 2023

IQzoneIT commented Oct 9, 2023

github-actions bot commented Oct 9, 2023

onkarvhanumante Oct 9, 2023 •

edited

Loading

IQzoneIT Oct 10, 2023

github-actions bot commented Oct 10, 2023

		@@ -0,0 +1,19 @@
		endpoint: "http://rtb.iqzone.com/?pid={{.SourceId}}&host={{.Host}}&pbs=1"

		@@ -0,0 +1,19 @@
		endpoint: "http://rtb.iqzone.com?pid={{.SourceId}}&host={{.Host}}&pbs=1"

		Message: fmt.Sprintf("Bid[%d].Ext.Prebid.Type expects one of the following values: 'banner', 'native', 'video', 'audio', got '%s'", bidId, bidExt.Prebid.Type),
		})

New Adapter: IQX #3164

New Adapter: IQX #3164

Conversation

IQzoneIT commented Sep 29, 2023 • edited Loading

github-actions bot Sep 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 29, 2023

Code coverage summary

iqx

github-actions bot commented Sep 29, 2023

Code coverage summary

iqx

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 3, 2023

Code coverage summary

iqx

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 3, 2023

Code coverage summary

iqx

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 9, 2023

Code coverage summary

iqx

IQzoneIT commented Oct 9, 2023

github-actions bot commented Oct 9, 2023

Code coverage summary

iqx

onkarvhanumante Oct 9, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 10, 2023

Code coverage summary

iqx

IQzoneIT commented Sep 29, 2023 •

edited

Loading

onkarvhanumante Oct 9, 2023 •

edited

Loading