Silvermob: host validation (us, eu, apac) #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
silvermobRefer here for heat map coverage report |
hhhjort
changed the title
| @@ -121,8 +133,14 @@ func (a *SilverMobAdapter) getImpressionExt(imp *openrtb2.Imp) (*openrtb_ext.Ext | |||
| } | |||
|
|
|||
| func (a *SilverMobAdapter) buildEndpointURL(params *openrtb_ext.ExtSilverMob) (string, error) { | |||
| endpointParams := macros.EndpointTemplateParams{ZoneID: params.ZoneID, Host: params.Host} | |||
| return macros.ResolveMacros(a.endpoint, endpointParams) | |||
| if isValidHost(params.Host) { | |||
There was a problem hiding this comment.
Please be mindful that your adapter has been flagged as it is currently using dynamic hosts. Please refer to the github issue here - #2612
There was a problem hiding this comment.
Yes, that's why we added this validation. Is it enough?
There was a problem hiding this comment.
You should strive to render the host non-dynamic by excluding the host parameter from the domain and use it as a query parameter instead. The domain name should remain constant.
There was a problem hiding this comment.
Ok, we will select a vendor for geo DNS and publish update within a couple of weeks
There was a problem hiding this comment.
@freemmy Please advise if you would like to make changes for geo DNS in this PR or a separate PR.
There was a problem hiding this comment.
I thing the next PR since it takes some time
Code coverage summaryNote:
silvermobRefer here for heat map coverage report |
gargcreation1992
approved these changes
Sep 25, 2023
Sonali-More-Xandr
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second level domains are being validated before usage. Allowed only eu.silvermob.com, us.silvermob.com and apac.silvermob.com