Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename adapters to bidders in alternate bidder codes config #2324

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

pm-nilesh-chate
Copy link
Contributor

@pm-nilesh-chate pm-nilesh-chate commented Jul 25, 2022

Rename adapters to bidders in alternate bidder codes config w.r.t #2174

Old pbs.yaml example:

account_defaults:
  alternatebiddercodes:
    enabled: true
    adapters:
      pubmatic:
        allowedbiddercodes: [groupm]
      appnexus:
        allowedbiddercodes: [*]

New pbs.yaml example:

account_defaults:
  alternatebiddercodes:
    enabled: true
    bidders:
      pubmatic:
        allowedbiddercodes: [groupm]
      appnexus:
        allowedbiddercodes: [*]

@pm-nilesh-chate pm-nilesh-chate changed the title Rename adapters to bidders in extra-bid feature's config Rename adapters to bidders in alternate bidder codes config Jul 25, 2022
@pm-nilesh-chate pm-nilesh-chate marked this pull request as ready for review July 25, 2022 03:56
@bsardo bsardo self-requested a review July 25, 2022 13:53
@bsardo bsardo self-assigned this Jul 25, 2022
Copy link
Collaborator

@bsardo bsardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SyntaxNode SyntaxNode self-requested a review July 25, 2022 14:16
@SyntaxNode SyntaxNode self-assigned this Jul 25, 2022
@SyntaxNode
Copy link
Contributor

Thank you putting this PR so quickly. I plan to merge it in later today. Let's leave a little more time for other folks from the community to comment on this breaking change (for a feature released 2 weeks ago). There's a thread on the Prebid Slack as well asking for feedback. There were no concerns voiced at the Prebid Server Committee meeting last week.

@bsardo bsardo merged commit b67cc64 into prebid:master Jul 25, 2022
pm-aadit-patil pushed a commit to PubMatic-OpenWrap/prebid-server that referenced this pull request Sep 22, 2022
pm-aadit-patil pushed a commit to PubMatic-OpenWrap/prebid-server that referenced this pull request Sep 22, 2022
pm-aadit-patil pushed a commit to PubMatic-OpenWrap/prebid-server that referenced this pull request Sep 22, 2022
jorgeluisrocha pushed a commit to jwplayer/prebid-server that referenced this pull request Sep 28, 2022
shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Nov 8, 2022
mobfxoHB pushed a commit to mobfxoHB/prebid-server that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants