Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adapters to set seat for a bid #2266

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Conversation

pm-nilesh-chate
Copy link
Contributor

@pm-nilesh-chate pm-nilesh-chate commented Jun 7, 2022

Implements #2174: Conventions and controls for adapters responding with multiple biddercodes

  • Populate new field seatbid.bid.ext.prebid.meta.adaptercode with the adapter code.
  • Allow adapters to set seat of bid(s).
  • PubMatic sets seat for bids with value from bid.ext.marketplace.
  • update existing tests
    • assert bid seat for all adapters.
    • update requestBid() mock to include seat and adaptercode.
  • add new tests
    • add exchange test to validate extra bids under new seat.
    • add exchange test to validate extra bids and their adaptercode under new seat of an alias bidder.
    • add test to assert requestBid() changes.
    • Add pubmatic adapter test to assert extra-bid and a new response ext field marketplace.
  • Validate extra-bidders as per phase-2 description.
  • Do bid adjustment for extra-bid as per phase-2 description.

Creating this new pull request as the original #2257 one was from wrong account.

@hhhjort Could you please approve this PR (no new changes). Apologies for the inconvenience.

hhhjort
hhhjort previously approved these changes Jun 9, 2022
Copy link
Collaborator

@bsardo bsardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Just a couple of comments.

exchange/bidder.go Outdated Show resolved Hide resolved
config/accounts.go Show resolved Hide resolved
config/accounts.go Outdated Show resolved Hide resolved
config/accounts.go Outdated Show resolved Hide resolved
config/accounts.go Outdated Show resolved Hide resolved
config/accounts_test.go Show resolved Hide resolved
errortypes/code.go Outdated Show resolved Hide resolved
@bsardo
Copy link
Collaborator

bsardo commented Jun 18, 2022

Thanks for the quick turnaround on the PR suggestions. Everything looks good. I'd just like to see what @hhhjort thinks about this #2266 (comment) above.

hhhjort
hhhjort previously approved these changes Jun 20, 2022
Copy link
Collaborator

@bsardo bsardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo merged commit 6776537 into prebid:master Jun 27, 2022
wwwyyy pushed a commit to wwwyyy/prebid-server that referenced this pull request Jul 5, 2022
* 'master' of https://github.com/wwwyyy/prebid-server:
  Read imp[].ext.tid, fix PBJS 7.3.0 compatibility (prebid#2283)
  New Adapter: Kargo (prebid#2268)
  VIS.X updated endpoint parameters (prebid#2282)
  New Adapter: InfyTV (prebid#2278)
  Support adapters to set seat for a bid (prebid#2266)
  VIS.X: add X-Forwarded-For header (prebid#2279)
  Unicorn: Revert limitation of JPY only ( add limitation of accountId ) (prebid#2277)
nayan9229 pushed a commit to infytvcode/prebid-server-go that referenced this pull request Sep 5, 2022
jorgeluisrocha pushed a commit to jwplayer/prebid-server that referenced this pull request Sep 28, 2022
shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants