-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support adapters to set seat for a bid #2266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. Just a couple of comments.
Thanks for the quick turnaround on the PR suggestions. Everything looks good. I'd just like to see what @hhhjort thinks about this #2266 (comment) above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* 'master' of https://github.com/wwwyyy/prebid-server: Read imp[].ext.tid, fix PBJS 7.3.0 compatibility (prebid#2283) New Adapter: Kargo (prebid#2268) VIS.X updated endpoint parameters (prebid#2282) New Adapter: InfyTV (prebid#2278) Support adapters to set seat for a bid (prebid#2266) VIS.X: add X-Forwarded-For header (prebid#2279) Unicorn: Revert limitation of JPY only ( add limitation of accountId ) (prebid#2277)
Implements #2174: Conventions and controls for adapters responding with multiple biddercodes
seatbid.bid.ext.prebid.meta.adaptercode
with the adapter code.seat
of bid(s).seat
for bids with value frombid.ext.marketplace
.seat
for all adapters.seat
andadaptercode
.seat
.adaptercode
under newseat
of an alias bidder.requestBid()
changes.pubmatic
adapter test to assert extra-bid and a new response ext fieldmarketplace
.Creating this new pull request as the original #2257 one was from wrong account.
@hhhjort Could you please approve this PR (no new changes). Apologies for the inconvenience.