YNGJ-1058: Create Aether Observatory #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A change to Portal catalog files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/catalog?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=yngj-1058-aether-observatory |
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=yngj-1058-aether-observatory |
rizenine
previously approved these changes
Dec 16, 2024
that-jill
reviewed
Dec 16, 2024
xjunior
reviewed
Dec 16, 2024
|
@that-jill and @xjunior I think I've got Appraisal set up correctly. Should it be testing all packages on all pushes? I tagged a version as v0.0.1pre4 that finally made it to rubygems. |
Use public interface rather than reaching into ActiveSupport::Notifications
dutchess
force-pushed
the
YNGJ-1058-aether-observatory
branch
from
6c3b831 to
b261766
Compare
rizenine
previously approved these changes
Dec 17, 2024
xjunior
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting
AetherObservatoryfromTalkbox. Internal PubSub system base uponActiveSupport::Notifications