Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert on unsupported client #230

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Alert on unsupported client #230

wants to merge 2 commits into from
+107 −0

Conversation

jonwmarshall
Copy link

@jonwmarshall jonwmarshall commented Jan 17, 2024 •
edited
Loading

Followup - when we have our wrapper, we'll need to update the cop to disallow using Net::HTTP directly in favor of it.

@jonwmarshall jonwmarshall requested a review from a team as a code owner January 17, 2024 14:45
@jonwmarshall jonwmarshall force-pushed the alert-on-unsupported-client branch from 45d5c77 to a84686d Compare January 17, 2024 14:47
garettarrowood
garettarrowood approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@garettarrowood garettarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for contributing!

xjunior
xjunior requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@xjunior xjunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have our wrapper published before we merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjunior xjunior xjunior requested changes

@garettarrowood garettarrowood garettarrowood approved these changes

@that-jill that-jill Awaiting requested review from that-jill

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonwmarshall @xjunior @garettarrowood