Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong cast in morse app #2436

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix wrong cast in morse app #2436

merged 2 commits into from
Dec 20, 2024
+9 −5

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Dec 19, 2024 •
edited
Loading

  • the new cpp syntex from some of the standard (iirc 11) don't need the (void)xxx. just give the type in argument and don't name it
  • the original cast for bool is wrong, it would always cast to true
  • this fix appear after Morse transmitter loop freeze #2430, the issue there isn't caused by here

@zxkmm zxkmm marked this pull request as ready for review December 19, 2024 14:09
@zxkmm zxkmm enabled auto-merge (squash) December 19, 2024 14:10
@zxkmm zxkmm marked this pull request as draft December 19, 2024 17:17
auto-merge was automatically disabled December 19, 2024 17:17

Pull request was converted to draft

@zxkmm zxkmm marked this pull request as ready for review December 19, 2024 18:22
@zxkmm zxkmm enabled auto-merge (squash) December 19, 2024 18:23
gullradriel
gullradriel approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@zxkmm zxkmm merged commit 55525ed into portapack-mayhem:next Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gullradriel gullradriel gullradriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxkmm @gullradriel