Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External apps #1469

Merged
merged 22 commits into from
Oct 2, 2023
Merged

External apps #1469

merged 22 commits into from
Oct 2, 2023

Conversation

bernd-herzog
Copy link
Contributor

@bernd-herzog bernd-herzog commented Oct 1, 2023 •
edited
Loading

This pull request adds a new type of applications that can run from sd card and don't use space in the firmware image.
Two apps are implemented:

replaces #1307

@kallanreed kallanreed mentioned this pull request Oct 1, 2023
Closed
kallanreed
kallanreed reviewed Oct 1, 2023
View reviewed changes
firmware/application/ui_external_items_menu_loader.cpp Outdated
gridItem.color = Color((uint16_t)application_information.icon_color);

auto bitmapData = new uint8_t[32];
Bitmap* bitmap = new Bitmap{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it'd be better if that type just handled all of the buffer allocation directly.

kallanreed
kallanreed approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@kallanreed kallanreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. This is really cool.
I left some comments for your consideration.

I do think that we should move the "Debug" page to under "Utilities" and add a new "Apps" page. Can be in another PR though.

kallanreed
kallanreed approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@kallanreed kallanreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can't wait to see this in nightly. 🚀

@gullradriel
Copy link
Member

That's dope

@gullradriel
Copy link
Member

gullradriel commented Oct 2, 2023 •
edited
Loading

Can't wait to move a maximum of apps to the sdcard, so the loaded one will have tons of space

gullradriel
gullradriel approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooooooo

@bernd-herzog bernd-herzog merged commit 7fdb1af into portapack-mayhem:next Oct 2, 2023
3 checks passed
@NotherNgineer
Copy link
Contributor

Love this!! except... PacMan isn't the same without SOUND! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kallanreed kallanreed kallanreed approved these changes

@gullradriel gullradriel gullradriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bernd-herzog @gullradriel @NotherNgineer @kallanreed