Skip to content

Commit

Permalink
Add changes from "fixed memory usage #2380" to about_simple file gene…
Browse files Browse the repository at this point in the history
…rator. (#2381)

* Generator for updating the about-page in PP from github.
* Rename generate_ui-about-simple.ccp.py to generate_ui-about-simple.cpp.py
* Adapt changes from "fixed memory usage #2380" to the file generator.
  • Loading branch information
LupusE authored Nov 22, 2024
1 parent b108d97 commit 280b8af
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions firmware/tools/generate_ui-about-simple.cpp.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,15 @@
import sys

cppheader = """#include "ui_about_simple.hpp"
#include <string_view>
#define ROLL_SPEED_FRAME_PER_LINE 60
// cuz frame rate of pp screen is probably 60, scroll per sec
namespace ui {
// Information: a line starting with a '#' will be yellow coloured
const std::"""
constexpr std::"""

cppfooter = """
AboutView::AboutView(NavigationView& nav) {
Expand All @@ -52,18 +53,18 @@
button_ok.focus();
};
for (const std::string& authors_line : authors_list) {
for (auto& authors_line : authors_list) {
// if it's starting with #, it's a title and we have to substract the '#' and paint yellow
if (authors_line.size() > 0) {
if (authors_line[0] == '#') {
menu_view.add_item(
{authors_line.substr(1, authors_line.size() - 1),
{(std::string)authors_line.substr(1, authors_line.size() - 1),
ui::Theme::getInstance()->fg_yellow->foreground,
nullptr,
nullptr});
} else {
menu_view.add_item(
{authors_line,
{(std::string)authors_line,
Theme::getInstance()->bg_darkest->foreground,
nullptr,
nullptr});
Expand Down Expand Up @@ -140,7 +141,7 @@ def get_contributors(url):

def generate_content(projects):
project_contrib = []
project_contrib.append("string authors_list[] = {\n")
project_contrib.append("string_view authors_list[] = {\n")
project_contrib.append(" \"# * List of contributors * \",\n")
for project in projects:
project_contrib.append(" \" \",\n")
Expand Down Expand Up @@ -169,7 +170,7 @@ def pp_create_ui_about_simple_cpp(cpp_file, cppheader, cppcontent, cppfooter):

def pp_change_ui_about_simple_cpp(cpp_file, cppcontent):
content = []
content_pattern = re.compile(r"string authors_list\[\] = {\n(?:\s+(?:.*,\n)+\s+.*};\n)", re.MULTILINE)
content_pattern = re.compile(r"string_view authors_list\[\] = {\n(?:\s+(?:.*,\n)+\s+.*};\n)", re.MULTILINE)

# Read original file
with open(cpp_file, 'r') as file:
Expand Down

0 comments on commit 280b8af

Please sign in to comment.