[Integration][Datadog] Datadog Teams and Users #1256
+280
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` for paginated data retrieval.
- Added `on_resync_teams()` to fetch and enrich teams with member information. - Added `on_resync_users()` to fetch users in batches. - Implemented `enrich_teams_with_members()` to parallelize team member retrieval.
- Added `TeamSelector` with `include_members` option to control member inclusion. - Added `TeamResourceConfig` to include team-specific configuration in the resource setup.
- Added `datadogTeam` and `datadogUser` blueprints to represent Datadog teams and users. - Introduced resource configurations for teams and users in `port-app-config.yaml`. - Added team and user support to `spec.yaml` to enable integration features. - Add team relation to datadog service blueprint - Fix team and service relationships using handle matching
- Renamed `get_paginated_team_members` to `get_team_members`. - Simplified logic for fetching and processing team members.
- Removed unused fields from `blueprints.json` and `port-app-config.yaml`. - Added descriptions
PeyGis
requested changes
Dec 20, 2024
Co-authored-by: PagesCoffy <[email protected]>
- Remove redundant logs from client and main - Add clear team enrichment notification log - Move team enrichment functionality to client class
…ps://github.com/port-labs/ocean into PORT-12104-Datadog-Enhancements-Users-and-Teams
…2104-Datadog-Enhancements-Users-and-Teams
phalbert
requested changes
Dec 23, 2024
phalbert
reviewed
Dec 24, 2024
integrations/datadog/main.py
Outdated
Comment on lines
46
to
48
| if selector.include_members: | ||
| teams = await dd_client.enrich_teams_with_members(teams) | ||
| yield teams |
There was a problem hiding this comment.
I think the enrich_teams_with_members should be just get_team_members and the logic of the merge will be in the main file
There was a problem hiding this comment.
Okay, makes sense. 👍 .
- Moved team member fetching directly into `on_resync_teams`.
…ps://github.com/port-labs/ocean into PORT-12104-Datadog-Enhancements-Users-and-Teams
…2104-Datadog-Enhancements-Users-and-Teams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What -
Added support for Datadog Teams and Users in the integration, including fetching, processing, and enriching data related to teams and users.
Why -
Enable users to associate monitors, SLOs, and other Datadog resources with specific teams and users
How -
resources/blueprints.jsonto define schemas for Datadog Teams and Users.client.pyto include methods for fetching teams and users, as well as members of specific teams.main.pylogic to enrich team data with associated members.resources/port-app-config.yamlto map Datadog Team and User properties to corresponding Port entities.Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examplesfolder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.