[Infra] Introduced multi stage build for images to improve built time #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzaadi
force-pushed
the
PORT-10788
branch
7 times, most recently
from
3ad1866 to
4547355
Compare
erikzaadi
force-pushed
the
PORT-10788
branch
3 times, most recently
from
0085ab3 to
1355b12
Compare
erikzaadi
force-pushed
the
PORT-10788
branch
4 times, most recently
from
a1e22c0 to
ddda5b6
Compare
erikzaadi
changed the title
Tankilevitch
requested changes
Oct 26, 2024
Comment on lines
44
to
46
| # - name: Setup docker (missing on MacOS) | ||
| # if: matrix.platform == 'linux/arm64' | ||
| # uses: douglascamata/setup-docker-macos-action@v1-alpha |
| @@ -0,0 +1,12 @@ | |||
| ARG BASE_PYTHON_IMAGE=debian:trixie-slim | |||
There was a problem hiding this comment.
can we choose specific python version? or atleast add a comment about what is the python version used here
| @@ -57,24 +52,13 @@ jobs: | |||
| needs: [prepare-matrix] | |||
| strategy: | |||
| # limit the number of parallel jobs to avoid hitting the ghcr.io rate limit | |||
| max-parallel: 5 | |||
| max-parallel: 10 | |||
There was a problem hiding this comment.
is it still within the rate limit treshold?
.github/workflows/infra.yml
Outdated
| detect-changes: | ||
| uses: ./.github/workflows/detect-changes-matrix.yml | ||
| build-infra: | ||
| # runs-on: ${{ matrix.platform == 'linux/arm64' && 'macos-13' || 'ubuntu-latest' }} |
Comment on lines
99
to
101
| skip-push: 'yupp' | ||
| tags: ${{ steps.enrich-version.outputs.image_tag }} | ||
| load: true | ||
| cache-from: type=gha | ||
| cache-to: type=gha,mode=max | ||
| load-created-image: 'yupp' |
.github/workflows/ci.yml
Outdated
| docker run --platform ${{ matrix.platform }} --rm --entrypoint bash "${SINGLE_TAG}" -c 'ocean version' | ||
| docker-user: ${{ secrets.DOCKER_MACHINE_USER }} | ||
| docker-password: ${{ secrets.DOCKER_MACHINE_TOKEN }} | ||
| skip-push: 'yupp' |
Tankilevitch
changed the title
Tankilevitch
approved these changes
Oct 27, 2024
.github/workflows/ci.yml
Outdated
| build-integration: | ||
| runs-on: ubuntu-latest | ||
| runs-on: 'ubuntu-latest' |
There was a problem hiding this comment.
Suggested change
| runs-on: 'ubuntu-latest' | |
| runs-on: ubuntu-latest |
.github/workflows/ci.yml
Outdated
| @@ -1,7 +1,6 @@ | |||
| name: Build integration images | |||
| on: | |||
| pull_request: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
we don't want to be able to run it manually?
.github/workflows/infra.yml
Outdated
28 tasks
mk-armah
pushed a commit
that referenced
this pull request
Oct 30, 2024
# Description What - Add `openssl` certificates to image Why - As part of separation of the images in #1079 the openssl installation was missed for the deb image How - ## Type of change Please leave one option from the following and delete the rest: - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] New Integration (non-breaking change which adds a new integration) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Non-breaking change (fix of existing functionality that will not change current behavior) - [ ] Documentation (added/updated documentation) <h4> All tests should be run against the port production environment(using a testing org). </h4> ### Core testing checklist - [ ] Integration able to create all default resources from scratch - [ ] Resync finishes successfully - [ ] Resync able to create entities - [ ] Resync able to update entities - [ ] Resync able to detect and delete entities - [ ] Scheduled resync able to abort existing resync and start a new one - [ ] Tested with at least 2 integrations from scratch - [ ] Tested with Kafka and Polling event listeners - [ ] Tested deletion of entities that don't pass the selector ### Integration testing checklist - [ ] Integration able to create all default resources from scratch - [ ] Resync able to create entities - [ ] Resync able to update entities - [ ] Resync able to detect and delete entities - [ ] Resync finishes successfully - [ ] If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the `examples` folder in the integration directory. - [ ] If resource kind is updated, run the integration with the example data and check if the expected result is achieved - [ ] If new resource kind is added or updated, validate that live-events for that resource are working as expected - [ ] Docs PR link [here](#) ### Preflight checklist - [ ] Handled rate limiting - [ ] Handled pagination - [ ] Implemented the code in async - [ ] Support Multi account ## Screenshots Include screenshots from your environment showing how the resources of the integration will look. ## API Documentation Provide links to the API documentation used for this integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Docker build improvements
What -
Why -
Releasing integrations took over 2 hours (!)
Type of change
Please leave one option from the following and delete the rest: