-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add mega-linter for linting #834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this? From what I can see it will use lintr
and cargo clippy
for linting so what is the advantage of using this compared to our existing formatting tools in the taskfile? Does this push changes automatically?
This is required for everything but R and Rust. Some linters have automatic fixes (auto commit), but I have turned them off for now. |
Looks like a very big tool for not many linting usages (the workflow takes about 2min to lint yaml and markdown files and we don't have many of them). If I remember correctly, it was Prettier that fixed the Markdown spaces for you locally. Maybe we could add a I see they also have a Github action, is it worth trying it as well? |
What I really want to run is editorconfg, but I can't find the proper action in GitHub Actions. Yes, the execution time is relatively long, but it is far better than no check. |
@etiennebacher I want to merge this so can you please take a look? |
I really think this is overkill for spaces in Markdown files. I merge it so we can move on but I'll open an issue to see if Prettier has a github action that is less massive |
I agree with that. However, what I am concerned about Mega-Linter is that it also reliably performs checks for things that are difficult to inspect locally, such as GitHub Actions. |
No description provided.