Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): fix indentation in changelog #636

Merged
merged 5 commits into from
Jan 1, 2024
Merged

docs(website): fix indentation in changelog #636

merged 5 commits into from
Jan 1, 2024

Conversation

etiennebacher
Copy link
Collaborator

Currently nested lists are flattened, this fixes it

@eitsupi
Copy link
Collaborator

eitsupi commented Dec 29, 2023

Does this mean altdoc or something is expecting an indent size of 4?
In that case, I think we need to force the indent size using something like Editorconfig.

@etiennebacher
Copy link
Collaborator Author

I think this is just required by mkdocs. The NEWS file in altdoc has nested lists with only 2 spaces and it works fine with the docute generator

In that case, I think we need to force the indent size using something like Editorconfig.

I'm not familiar with this, does it work with any IDE?

@eitsupi
Copy link
Collaborator

eitsupi commented Dec 30, 2023

I'm not familiar with this, does it work with any IDE?

Yes, except for RStudio IDE. (rstudio/rstudio#1711)

@etiennebacher
Copy link
Collaborator Author

@eitsupi I don't know how to enable Editorconfig, so feel free to merge this when ready

Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks!

@eitsupi eitsupi merged commit db9bba7 into main Jan 1, 2024
16 checks passed
@eitsupi eitsupi deleted the indent-news branch January 1, 2024 06:45
@eitsupi
Copy link
Collaborator

eitsupi commented Mar 11, 2024

This is the upstream issue mkdocs/mkdocs#545 (comment)

@eitsupi
Copy link
Collaborator

eitsupi commented Mar 11, 2024

Fixed in #910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants