Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not drop first queue member if drop handler #416

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Conversation

sorhawell
Copy link
Collaborator

@sorhawell sorhawell commented Oct 8, 2023

resolves #413

If limiting cap and thereby active processes, while job queue was not empty, the first queue member would be dropped and never handled.

Solution: Just put first queue member back into queue, if no process is available due to downsizing of cap and active.

@sorhawell
Copy link
Collaborator Author

@eitsupi if I want to limit a test to only run in CI and not in interactive dev, because very exotic and takes a few seconds to run, should I do something like "skip if not en var CI='true' "?

@sorhawell sorhawell marked this pull request as ready for review October 8, 2023 19:35
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know how to gauge this. (Example in #413 no longer works.)
Since it seems to pass the test, is it safe to merge it?

@sorhawell
Copy link
Collaborator Author

It should also work with example in #413 I will check again and then merge. I added a test which should cause the same error , but it is as simple as possible to still cause the original error.

@sorhawell sorhawell merged commit 326c370 into main Oct 10, 2023
11 checks passed
@sorhawell sorhawell deleted the fix_rbackground_bug branch October 10, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RBackGroundPool bug when modifying cap multiple times
2 participants