Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix release workflow to enable full features of Linux arm64 packages on GitHub releases #394

Merged
merged 2 commits into from
Sep 24, 2023
Merged

ci: fix release workflow to enable full features of Linux arm64 packages on GitHub releases #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0d7621
ci: fix trigger of release workflow
eitsupi Sep 24, 2023
7d5af10
fix: `==` -> `=`
eitsupi Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
on:
push:
branches: [main]
tags:
- "**" # Push events to every tag including hierarchical tags like v1.0/beta
pull_request:
branches:
- main
paths:
- .github/workflows/release.yaml
- src/Makevars*
workflow_dispatch:

name: Release
Expand Down
4 changes: 2 additions & 2 deletions src/Makevars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ $(STATLIB):
export CARGO_HOME=$(CARGOTMP); \
fi && \
export PATH="$(PATH):$(HOME)/.cargo/bin" && \
if [ "$(RPOLARS_FULL_FEATURES)" == "true" ]; then \
if [ "$(RPOLARS_FULL_FEATURES)" = "true" ]; then \
$(BUILD_COMMAND) --features "full_features"; \
else \
$(BUILD_COMMAND); \
Expand All @@ -44,7 +44,7 @@ $(STATLIB):
ln -s $(rpolars_ext_binary) $(STATLIB) ; \
fi

if [ "$(RPOLARS_CARGO_CLEAN_DEPS)" == "true" ]; then \
if [ "$(RPOLARS_CARGO_CLEAN_DEPS)" = "true" ]; then \
echo "cleanup!!" ; \
mv $(STATLIB) $(LIBDIR)/../temp_binary.a; \
rm -rf $(LIBDIR); \
Expand Down
4 changes: 2 additions & 2 deletions src/Makevars.win
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ $(STATLIB):
fi && \
export CARGO_TARGET_X86_64_PC_WINDOWS_GNU_LINKER="$(CARGO_LINKER)" && \
export LIBRARY_PATH="$${LIBRARY_PATH};$(CURDIR)/$(TARGET_DIR)/libgcc_mock" && \
if [ "$(RPOLARS_FULL_FEATURES)" == "true" ]; then \
if [ "$(RPOLARS_FULL_FEATURES)" = "true" ]; then \
$(BUILD_COMMAND) --features "full_features"; \
else \
$(BUILD_COMMAND); \
Expand All @@ -52,7 +52,7 @@ $(STATLIB):
fi

# CRAN might even need more files to be gone, delete them here...
if [ "$(RPOLARS_CARGO_CLEAN_DEPS)" == "true" ]; then \
if [ "$(RPOLARS_CARGO_CLEAN_DEPS)" = "true" ]; then \
echo "clean up target, to not let R CMD check fail on rust files"; \
mv $(STATLIB) $(LIBDIR)/../temp_binary.a; \
rm -rf $(LIBDIR); \
Expand Down