-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add argument include_file_paths
in pl_scan_csv
#1238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me, there are just a couple of things to fix in tests.
Also, can you add a bullet point in NEWS.md indicating the new feature and the PR number (and your github username if you want)?
Made a commit with the asked modifications. |
Almost done, you just need to redocument. You can use |
Done. |
I cleaned up the PR, I think the extra changes in That's a nice first contribution, thanks @collioud! |
You made this easy! |
Context
The argument
include_file_paths
is missing from thepl_scan_csv
andpl_read_csv
functions whereas it is available for otherpl_read_...
fonctions (for example,pl_read_parquet
).Close #1235
Goal of this PR
Add the argument
include_file_paths
to thepl_scan_csv
andpl_read_csv
functions.Adjust the related documentation.
Tests
Not tested yet
Hope this will help the project!
Cheers